Update contract initializer #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also modify the tests and migrations to respect the new structure. This change will remove non-necessary migrations to be cleaner.
jayantk
approved these changes
Nov 28, 2022
…ontract-initializer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also modify the tests and migrations to respect the new structure. This change will remove non-necessary migrations to result in a cleaner migration path. It also reduces the deployment costs.
Due to changing the initializer the contract size became larger than max accepted size (24kb) and I reduced the optimizer runs. In a separate PR I'll try to convert our error messages to proper structs to reduce the size based on @njkumr suggestion.
For ^^^ I added truffle-contract-size plugin and by running
npx truffle run contract-size(after compiling the contracts) you can see the size of the contracs.