This repository was archived by the owner on May 6, 2025. It is now read-only.
Abehjati/fix-mem-layout #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly based on solsecurity
jayantk
previously approved these changes
Aug 23, 2022
tompntn
previously approved these changes
Aug 23, 2022
|
Nice! I wonder if we should add solsecurity to the CI/CD for the Solidity contracts? |
|
I'm not sure whether they have CI/CD, do they? I thought it's more of a guideline for the auditors. |
Co-authored-by: Tom Pointon <tom@teepeestudios.net>
tompntn
approved these changes
Aug 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also some refactorings based on solsecurity
The main reason for this change is that
updatePriceFeedsin the actual contract (in pyth-crosschain) and a function that it calls usecalldataandupdatePriceFeedsIfNecessaryis passing amemoryargument. It causes a revert becausememorycannot be converted tocalldata(in a local function call).We could've have change the contract to use
memorybut usingcalldatahere is more gas efficients and avoids a copy.