Abehjati/fix-mem-layout (#25)

* Update mem modifiers + refactor

Mostly based on solsecurity

* Bump version to 0.5.2

* Fix formatting

* Update MockPyth.sol

Co-authored-by: Tom Pointon <tom@teepeestudios.net>

Co-authored-by: Tom Pointon <tom@teepeestudios.net>

Author: ali-behjati

AbstractPyth.sol

@@ -54,7 +54,7 @@ abstract contract AbstractPyth is IPyth {
         return price;
     }
 
-    function diff(uint x, uint y) private pure returns (uint) {
+    function diff(uint x, uint y) internal pure returns (uint) {
         if (x > y) {
             return x - y;
         } else {
@@ -63,9 +63,9 @@ abstract contract AbstractPyth is IPyth {
     }
 
     // Access modifier is overridden to public to be able to call it locally.
-    function updatePriceFeeds(bytes[] memory updateData) public virtual payable override;
+    function updatePriceFeeds(bytes[] calldata updateData) public virtual payable override;
 
-    function updatePriceFeedsIfNecessary(bytes[] memory updateData, bytes32[] memory priceIds, uint64[] memory publishTimes) external payable override {
+    function updatePriceFeedsIfNecessary(bytes[] calldata updateData, bytes32[] calldata priceIds, uint64[] calldata publishTimes) external payable override {
         require(priceIds.length == publishTimes.length, "priceIds and publishTimes arrays should have same length");
 
         bool updateNeeded = false;

IPyth.sol

@@ -72,7 +72,7 @@ interface IPyth {
     /// The call will succeed even if the update is not the most recent.
     /// @dev Reverts if the transferred fee is not sufficient or the updateData is invalid.
     /// @param updateData Array of price update data.
-    function updatePriceFeeds(bytes[] memory updateData) external payable;
+    function updatePriceFeeds(bytes[] calldata updateData) external payable;
 
     /// @notice Wrapper around updatePriceFeeds that rejects fast if a price update is not necessary. A price update is
     /// necessary if the current on-chain publishTime is older than the given publishTime. It relies solely on the
@@ -90,7 +90,7 @@ interface IPyth {
     /// @param updateData Array of price update data.
     /// @param priceIds Array of price ids.
     /// @param publishTimes Array of publishTimes. `publishTimes[i]` corresponds to known `publishTime` of `priceIds[i]`
-    function updatePriceFeedsIfNecessary(bytes[] memory updateData, bytes32[] memory priceIds, uint64[] memory publishTimes) external payable;
+    function updatePriceFeedsIfNecessary(bytes[] calldata updateData, bytes32[] calldata priceIds, uint64[] calldata publishTimes) external payable;
 
     /// @notice Returns the required fee to update an array of price updates.
     /// @param updateDataSize Number of price updates.

MockPyth.sol

@@ -22,10 +22,14 @@ contract MockPyth is AbstractPyth {
     // Takes an array of encoded price feeds and stores them.
     // You can create this data either by calling createPriceFeedData or
     // by using web3.js or ethers abi utilities.
-    function updatePriceFeeds(bytes[] memory updateData) public override payable {
+    function updatePriceFeeds(bytes[] calldata updateData) public override payable {
         uint requiredFee = getUpdateFee(updateData.length);
         require(msg.value >= requiredFee, "Insufficient paid fee amount");
-        payable(msg.sender).transfer(msg.value - requiredFee);
+
+        if (msg.value > requiredFee) {
+            (bool success, ) = payable(msg.sender).call{value: msg.value - requiredFee}("");
+            require(success, "failed to transfer update fee");
+        }
 
         uint freshPrices = 0;
 

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@pythnetwork/pyth-sdk-solidity",
-  "version": "0.5.1",
+  "version": "0.5.2",
   "description": "Read prices from the Pyth oracle",
   "repository": {
     "type": "git",