Skip to content

chore(target_chains/ethereum): cut a release for price feeds contracts #2683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

chore(target_chains/ethereum): cut a release for price feeds contracts #2683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion target_chains/ethereum/contracts/contracts/entropy/Entropy.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,7 +1081,7 @@ abstract contract Entropy is IEntropy, EntropyState {
_state.seed = keccak256(
abi.encodePacked(
block.timestamp,
block.difficulty,
block.prevrandao,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't change the behaviour, after the ethereum merge (PoW -> PoS) this was repurposed to be the pseudo random number that beacon chain creates.

msg.sender,
_state.seed
)
Expand Down
2 changes: 1 addition & 1 deletion target_chains/ethereum/contracts/contracts/pyth/Pyth.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,7 @@ abstract contract Pyth is
}

function version() public pure returns (string memory) {
return "1.4.4-alpha.5";
return "1.4.4";
}

/// @notice Calculates TWAP from two price points
Expand Down
2 changes: 1 addition & 1 deletion target_chains/ethereum/contracts/forge-test/Echo.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,7 +1171,7 @@ contract EchoTest is Test, EchoEvents, IEchoConsumer, EchoTestUtils {
assertApproxEqRel(
gas2Used,
gas1Used * 2,
0.1e18, // 10% tolerance
0.2e18, // 20% tolerance
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tejasbadadare strangely the difference got to 19% here which probably means that it has got more optimized so does a better job on longer operations.

Copy link
Contributor

@tejasbadadare tejasbadadare May 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow nice. The alternative explanation is that gas2Used went up and that the gas scaling isn't as linear as we thought :P

"Gas usage should scale roughly linearly"
);
}
Expand Down
2 changes: 1 addition & 1 deletion target_chains/ethereum/contracts/foundry.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[profile.default]
solc_version = '0.8.4'
solc_version = '0.8.29'
optimizer = true
optimizer_runs = 200
src = 'contracts'
Expand Down
2 changes: 1 addition & 1 deletion target_chains/ethereum/contracts/hardhat.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ module.exports = {
],
},
solidity: {
version: "0.8.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tradeoffs for going back a compiler version?

Also it's weird that the solidity github's latest release is 0.8.3 but 0.8.4 came out years ago ...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the latest release is 0.8.30*

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh lol i mixed up 0.8.3 and 0.8.30 🤦

version: "0.8.29",
settings: {
optimizer: {
enabled: true,
Expand Down
2 changes: 1 addition & 1 deletion target_chains/ethereum/contracts/truffle-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ module.exports = {

compilers: {
solc: {
version: "0.8.4",
version: "0.8.29",
settings: {
optimizer: {
enabled: true,
Expand Down
Loading