chore(target_chains/ethereum): cut a release for price feeds contracts #2683
Conversation
ali-behjati
force-pushed
the
target_chains/eth/update-solc-and-cut-release
branch
from
e00b53d to
f7a906f
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -1081,7 +1081,7 @@ abstract contract Entropy is IEntropy, EntropyState { | |||
| _state.seed = keccak256( | |||
| abi.encodePacked( | |||
| block.timestamp, | |||
| block.difficulty, | |||
| block.prevrandao, | |||
There was a problem hiding this comment.
this doesn't change the behaviour, after the ethereum merge (PoW -> PoS) this was repurposed to be the pseudo random number that beacon chain creates.
| @@ -1171,7 +1171,7 @@ contract EchoTest is Test, EchoEvents, IEchoConsumer, EchoTestUtils { | |||
| assertApproxEqRel( | |||
| gas2Used, | |||
| gas1Used * 2, | |||
| 0.1e18, // 10% tolerance | |||
| 0.2e18, // 20% tolerance | |||
There was a problem hiding this comment.
@tejasbadadare strangely the difference got to 19% here which probably means that it has got more optimized so does a better job on longer operations.
There was a problem hiding this comment.
Oh wow nice. The alternative explanation is that gas2Used went up and that the gas scaling isn't as linear as we thought :P
ali-behjati
force-pushed
the
target_chains/eth/update-solc-and-cut-release
branch
from
f7a906f to
a557424
Compare
| @@ -112,7 +112,7 @@ module.exports = { | |||
| ], | |||
| }, | |||
| solidity: { | |||
| version: "0.8.4", | |||
There was a problem hiding this comment.
Any tradeoffs for going back a compiler version?
Also it's weird that the solidity github's latest release is 0.8.3 but 0.8.4 came out years ago ...
There was a problem hiding this comment.
the latest release is 0.8.30*
There was a problem hiding this comment.
Oh lol i mixed up 0.8.3 and 0.8.30 🤦
There was a problem hiding this comment.
Nice!! Tried this out with the strict mininal updateData parsing PR and we're ~1k bytes within limit. I'll merge that one once this lands.
Summary
Updates the solc compiler to 0.8.29 (the version before latest version) so the contracts fit the contract size limit. I checked a few explorers to make sure they support this solc version. See the comments on some adjustments.
How has this been tested?