Backport #9417 to 6.2.x #9571
Merged
Backport #9417 to 6.2.x #9571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Ok, I'll open PRs for them too. I was mostly concerned about tests that failed for me locally. |
|
…aaaand done. |
(cherry picked from commit 47df71d)
nicoddemus
force-pushed
the
backport-9417
branch
from
200603f to
741c848
Compare
|
Thanks! Merge those, and took the liberty of rebasing this one. |
nicoddemus
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please backport the py3.10 fix to 6.2.x. It applies cleanly and fixes the test failures. It will take some time before everyone's ready for 7.0.0, so fixing 6.2.x seems to be the right thing to do.