-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix test_errors_in_xfail_skip_expressions for Python 3.10.1 #9417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
approved these changes
Dec 16, 2021
4d6c859
to
ccbbaae
Compare
Decided to remove the condition altogether as seems reasonable to state that our own test suite requires Python 3.10.1. Fix pytest-dev#9413
ccbbaae
to
913439f
Compare
nicoddemus
commented
Dec 16, 2021
@@ -78,7 +78,7 @@ jobs: | |||
os: windows-latest | |||
tox_env: "py39-xdist" | |||
- name: "windows-py310" | |||
python: "3.10-dev" | |||
python: "3.10.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: for now it seems 3.10.1
is not the default image if we just leave it as "3.10"
(it installs 3.10.0
in that case).
We probably want to change this to "3.10"
once it installs 3.10.1
(or later).
Backport: #9418 |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Dec 22, 2021
https://build.opensuse.org/request/show/941699 by user mcepl + dimstar_suse - Using URLs for Patches looks like a great idea, but it is too unstable. Please, don't. - Add pytest-pr8664-py3.10-test_trial_error-fail.patch * gh#pytest-dev/pytest#8664 - Add pytest-pr9417-py3.10.1-fail.patch * gh#pytest-dev/pytest#9417 - Disable libalternatives usage until all python-pytest* packages are on the same page (see sr#926611) - Disable all update-alternatives install calls if libalternatives is used. - Use libalternatives instead of update-alternatives.
mgorny
pushed a commit
to mgorny/pytest
that referenced
this pull request
Jan 28, 2022
(cherry picked from commit 47df71d)
nicoddemus
added a commit
to mgorny/pytest
that referenced
this pull request
Jan 29, 2022
(cherry picked from commit 47df71d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to remove the condition altogether as seems reasonable to state
that our own test suite requires Python 3.10.1.
Fix #9413