Skip to content

Add develop instructions to CONTRIBUTING #6249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

nicoddemus
Copy link
Member

From: #6244

Copy link
Contributor

@blueyed blueyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicoddemus
Copy link
Member Author

Cool, thanks for the review. 👍

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If we recommend .venv/, it will be good to add it to .gitignore.

@nicoddemus
Copy link
Member Author

If we recommend .venv/, it will be good to add it to .gitignore.

Yeah, now that you mention, that's why my gut feeling was using .env in the first place (that's on .gitignore already).

But no worries, added .venv to .gitignore as well.

@nicoddemus nicoddemus merged commit 490c7c7 into pytest-dev:master Nov 21, 2019
@nicoddemus nicoddemus deleted the devel-install branch November 21, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants