Skip to content

tests: skip tests without xmlschema #6244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Nov 20, 2019

No description provided.

@bluetech
Copy link
Member

Given that this package is in the testing extra, when will it not be available?

@blueyed
Copy link
Contributor Author

blueyed commented Nov 20, 2019

It does not have to be installed necessarily, i.e. when just doing pip install -e ..
This is just for convenience, and leaves a better impression when tests are working out of the box.
(it will still fail due to hypothesis here, but that's not easy to fix)
Feel free to close, I just thought it's easy to upstream.

@nicoddemus
Copy link
Member

Thanks @blueyed, but this means most (if not all) tests from junitxml will get skipped if the user does not have xmlschema installed. This might be frustrating because a user will inavertidely get a successfull test run, but there might be broken junitxml tests which will only appear then in CI.

I prefer we advertise users working on the tests to always use pip install -e .[testing] to avoid our test suite having to work around incomplete virtual environments.

@nicoddemus nicoddemus closed this Nov 20, 2019
@blueyed blueyed deleted the xmlschema branch November 20, 2019 23:27
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Nov 20, 2019
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Nov 20, 2019
blueyed added a commit to blueyed/pytest that referenced this pull request Nov 21, 2019
blueyed added a commit to blueyed/pytest that referenced this pull request Nov 21, 2019
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Nov 21, 2019
blueyed added a commit to blueyed/pytest that referenced this pull request Dec 2, 2019
vinaycalastry pushed a commit to vinaycalastry/pytest that referenced this pull request Dec 11, 2019
blueyed added a commit to blueyed/pytest that referenced this pull request Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants