Skip to content

Replace the _stop method, which was removed from aiosmtp 1.4.3, with the cancel_tasks method #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2023

Conversation

henri-hulski
Copy link
Contributor

Fixes #53 .

@henri-hulski henri-hulski changed the title Replace the Server._stop method, which was removed from aiosmtp with Server.cancel_tasks Replace the _stop method, which was removed from aiosmtp 1.4.3, with the cancel_tasks method Jan 20, 2023
@diazona
Copy link
Contributor

diazona commented Jan 20, 2023

Thanks! So this looks fine; I'd just like to get the tests on Python <3.7 working before I merge. (Or, if it's too much effort, we can just drop compatibility with those old versions of Python.) I'll work on fixing the tests today or tomorrow.

@henri-hulski
Copy link
Contributor Author

Ok. It seems quite difficult to maintain Python < 3.7. Github Actions doesn't seem to support it.
So I think it's fine to drop it.

@diazona
Copy link
Contributor

diazona commented Jan 21, 2023

It's not difficult, we just have to use an older version of Ubuntu. I made that fix in #56.

Anyway, it looks like these two pull requests need each other in order to get all the tests passing: yours fixes the tests on Python 3.7 and up, while mine fixes the tests on Python 3.6 and lower. So I'll probably just merge them both and hope that all the tests pass on master when it's done. But I would like to do it tomorrow because it's 2:30 AM for me right now 😄 (my personal rule of thumb: always wait a day before merging a PR, it helps catch stupid mistakes). Then perhaps I'll make a prerelease version early next week and you can test it, to be followed by a final release later in the week.

@diazona diazona merged commit 975d5a5 into pytest-dev:master Jan 22, 2023
@diazona
Copy link
Contributor

diazona commented Jan 22, 2023

Hooray it works 😄

I uploaded a prerelease version (v0.7.1a0) to PyPI to get this fix published for people who need it. If you can, give it a try and if you still have any problems, create a new issue. If no other problems come up, I'll aim to make a final release with this bug fix later this coming week.

@henri-hulski
Copy link
Contributor Author

Great! 🎉
I will try it out.
If I gonna have any problems I tell you.
Actually already changed it in the venv and so far everything works fine.

@henri-hulski henri-hulski deleted the smtp_stop branch January 22, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: SMTP throws AttributeError on teardown
2 participants