Mark the package as incompatible with aiosmtpd 1.4.3 #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiosmtpd 1.4.3 removed the method aiosmtpd.controller.Controller._stop() which this package's SMTP server implementation was using. That broke the SMTP server plugin. This is my fault; it wasn't a good idea to use a private method from another package, but I was in a hurry to get something working and I didn't get to figure out how to implement the SMTP server using only the public API of aiosmtpd. We're working on a proper fix - see issue #53 - but for now I'm just marking this package as incompatible with aiosmtpd 1.4.3 and up, as an aid to people trying to resolve dependencies.
|
Actually I think it's better to just merge #55 so I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aiosmtpd 1.4.3 removed the method aiosmtpd.controller.Controller._stop() which this package's SMTP server implementation was using. That broke the SMTP server plugin. This is my fault; it wasn't a good idea to use a private method from another package, but I was in a hurry to get something working and I didn't get to figure out how to implement the SMTP server using only the public API of aiosmtpd.
We're working on a proper fix - see issue #53 - but for now I'm just marking this package as incompatible with aiosmtpd 1.4.3 and up, as an aid to people trying to resolve dependencies.
I'd like to push a post-release version (0.7.0.post0) with this change.