Adding zip_safe=False to setup.py's. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should reference 'result_code' instead of 'result'. Fairly certain this arose from commit cb64e339 on jonparrott/nox, but no point digging into it now.
Using: * Python 2.7.12 and 3.5.2 * setuptools 36.6.0 * pip 9.0.1 * wheel 0.30.0
This prevents zipped eggs from being installed, and seems to improve overall compatiblity, as discussed in #6. Installations now pass in 95/160 combos, instead of only 72/160.
For posterity.
theacodes
approved these changes
Nov 1, 2017
|
Thank you so much for doing this, @swolebro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #6.
Also fixed a bug in report_to_table.py (probably caused by updates to nox), and added some notes to save future hair pulling.