Merge pull request #7 from swolebro/master

Adding zip_safe=False to setup.py's.

README.md

@@ -24,3 +24,9 @@ markdown-friendly table.
 # Current status
 
 To see the status since the last time the scenarios were run open [table.md](table.md).
+
+Please note:
+* Mixing package types within a single namespace is not supported. While it may work in some cases, it may also break depending on the software versions used, the install commands issued, or the order of commands. Don't mix types.
+* The `pkg_resources` method of namspacing is [no longer recommended](https://packaging.python.org/guides/packaging-namespace-packages/#pkg-resources-style-namespace-packages) and there is [the desire to deprecate it](https://github.com/pypa/python-packaging-user-guide/issues/265#issuecomment-290812581). It should only be used in legacy namespaces that already rely on it.
+* [PEP 420](https://www.python.org/dev/peps/pep-0420/) was accepted as part of Python 3.3. For wider compatibility (going back to Python 2.3), use the `pkgutil` method.
+* Zipped eggs don't play nicely with namespace packaging, and may be implicitly installed by commands like `python setup.py install`. To prevent this, it is recommended that you set [`zip_safe=False`](http://setuptools.readthedocs.io/en/latest/setuptools.html#setting-the-zip-safe-flag) in `setup.py`, as we do here.

native/pkg_a/setup.py

@@ -28,5 +28,6 @@
 
     license='Apache Software License',
 
-    packages=['example_pkg.a']
+    packages=['example_pkg.a'],
+    zip_safe=False,
 )

native/pkg_b/setup.py

@@ -29,4 +29,5 @@
     license='Apache Software License',
 
     packages=['example_pkg.b'],
+    zip_safe=False,
 )

pkg_resources/pkg_a/setup.py

@@ -29,5 +29,6 @@
     license='Apache Software License',
 
     packages=find_packages(),
-    namespace_packages=['example_pkg']
+    namespace_packages=['example_pkg'],
+    zip_safe=False,
 )

pkg_resources/pkg_b/setup.py

@@ -29,5 +29,6 @@
     license='Apache Software License',
 
     packages=find_packages(),
-    namespace_packages=['example_pkg']
+    namespace_packages=['example_pkg'],
+    zip_safe=False,
 )

pkgutil/pkg_a/setup.py

@@ -29,4 +29,5 @@
     license='Apache Software License',
 
     packages=find_packages(),
+    zip_safe=False,
 )

pkgutil/pkg_b/setup.py

@@ -29,4 +29,5 @@
     license='Apache Software License',
 
     packages=find_packages(),
+    zip_safe=False,
 )

report_to_table.py

@@ -17,5 +17,5 @@
             session['args']['interpreter'],
             ' '.join(session['args']['command_a']),
             ' '.join(session['args']['command_b']),
-            u'✅' if session['result'] else u'❌'
+            u'✅' if session['result_code'] else u'❌'
         ))

table.md

@@ -1,3 +1,10 @@
+| Tool | Version(s) |
+| --- | --- |
+| python | 2.7.12, 3.5.2 |
+| setuptools | 36.6.0 |
+| pip | 9.0.1 |
+| wheel | 0.30.0 |
+
 | Type | Interpreter | Package A command | Package B command | Status |
 | --- | --- | --- | --- | --- |
 | cross_pep420_pkgutil | python2 | pip install . | pip install . | ✅ |
@@ -24,10 +31,10 @@
 | cross_pep420_pkgutil | python3 | pip install -e . | pip install -e . | ✅ |
 | cross_pep420_pkgutil | python3 | pip install -e . | python setup.py install | ✅ |
 | cross_pep420_pkgutil | python3 | pip install -e . | python setup.py develop | ✅ |
-| cross_pep420_pkgutil | python3 | python setup.py install | pip install . | ❌ |
-| cross_pep420_pkgutil | python3 | python setup.py install | pip install -e . | ❌ |
-| cross_pep420_pkgutil | python3 | python setup.py install | python setup.py install | ❌ |
-| cross_pep420_pkgutil | python3 | python setup.py install | python setup.py develop | ❌ |
+| cross_pep420_pkgutil | python3 | python setup.py install | pip install . | ✅ |
+| cross_pep420_pkgutil | python3 | python setup.py install | pip install -e . | ✅ |
+| cross_pep420_pkgutil | python3 | python setup.py install | python setup.py install | ✅ |
+| cross_pep420_pkgutil | python3 | python setup.py install | python setup.py develop | ✅ |
 | cross_pep420_pkgutil | python3 | python setup.py develop | pip install . | ✅ |
 | cross_pep420_pkgutil | python3 | python setup.py develop | pip install -e . | ✅ |
 | cross_pep420_pkgutil | python3 | python setup.py develop | python setup.py install | ✅ |
@@ -40,7 +47,7 @@
 | cross_pkg_resources_pkgutil | python2 | pip install -e . | pip install -e . | ❌ |
 | cross_pkg_resources_pkgutil | python2 | pip install -e . | python setup.py install | ❌ |
 | cross_pkg_resources_pkgutil | python2 | pip install -e . | python setup.py develop | ❌ |
-| cross_pkg_resources_pkgutil | python2 | python setup.py install | pip install . | ❌ |
+| cross_pkg_resources_pkgutil | python2 | python setup.py install | pip install . | ✅ |
 | cross_pkg_resources_pkgutil | python2 | python setup.py install | pip install -e . | ✅ |
 | cross_pkg_resources_pkgutil | python2 | python setup.py install | python setup.py install | ✅ |
 | cross_pkg_resources_pkgutil | python2 | python setup.py install | python setup.py develop | ✅ |
@@ -56,7 +63,7 @@
 | cross_pkg_resources_pkgutil | python3 | pip install -e . | pip install -e . | ❌ |
 | cross_pkg_resources_pkgutil | python3 | pip install -e . | python setup.py install | ❌ |
 | cross_pkg_resources_pkgutil | python3 | pip install -e . | python setup.py develop | ❌ |
-| cross_pkg_resources_pkgutil | python3 | python setup.py install | pip install . | ❌ |
+| cross_pkg_resources_pkgutil | python3 | python setup.py install | pip install . | ✅ |
 | cross_pkg_resources_pkgutil | python3 | python setup.py install | pip install -e . | ✅ |
 | cross_pkg_resources_pkgutil | python3 | python setup.py install | python setup.py install | ✅ |
 | cross_pkg_resources_pkgutil | python3 | python setup.py install | python setup.py develop | ✅ |
@@ -82,19 +89,19 @@
 | pep420 | python2 | python setup.py develop | python setup.py develop | ❌ |
 | pep420 | python3 | pip install . | pip install . | ✅ |
 | pep420 | python3 | pip install . | pip install -e . | ✅ |
-| pep420 | python3 | pip install . | python setup.py install | ❌ |
+| pep420 | python3 | pip install . | python setup.py install | ✅ |
 | pep420 | python3 | pip install . | python setup.py develop | ✅ |
 | pep420 | python3 | pip install -e . | pip install . | ✅ |
 | pep420 | python3 | pip install -e . | pip install -e . | ✅ |
-| pep420 | python3 | pip install -e . | python setup.py install | ❌ |
+| pep420 | python3 | pip install -e . | python setup.py install | ✅ |
 | pep420 | python3 | pip install -e . | python setup.py develop | ✅ |
-| pep420 | python3 | python setup.py install | pip install . | ❌ |
-| pep420 | python3 | python setup.py install | pip install -e . | ❌ |
-| pep420 | python3 | python setup.py install | python setup.py install | ❌ |
-| pep420 | python3 | python setup.py install | python setup.py develop | ❌ |
+| pep420 | python3 | python setup.py install | pip install . | ✅ |
+| pep420 | python3 | python setup.py install | pip install -e . | ✅ |
+| pep420 | python3 | python setup.py install | python setup.py install | ✅ |
+| pep420 | python3 | python setup.py install | python setup.py develop | ✅ |
 | pep420 | python3 | python setup.py develop | pip install . | ✅ |
 | pep420 | python3 | python setup.py develop | pip install -e . | ✅ |
-| pep420 | python3 | python setup.py develop | python setup.py install | ❌ |
+| pep420 | python3 | python setup.py develop | python setup.py install | ✅ |
 | pep420 | python3 | python setup.py develop | python setup.py develop | ✅ |
 | pkg_resources | python2 | pip install . | pip install . | ✅ |
 | pkg_resources | python2 | pip install . | pip install -e . | ✅ |