Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix renderer ignore #230

Merged
merged 4 commits into from
Mar 14, 2022
Merged

Fix renderer ignore #230

merged 4 commits into from
Mar 14, 2022

Commits on Mar 12, 2022

  1. Require error codes for type: ignore

    @bhrutledge
    bhrutledge committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    4832356 View commit details
    Browse the repository at this point in the history

  2. Fix type: ignore of renderer variants 

    Based on:
https://mypy.readthedocs.io/en/stable/kinds_of_types.html#callable-types-and-lambdas

mypy can infer lambda types; it seems we just need to annotate the
lookup dict.
    @bhrutledge
    bhrutledge committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    4ea472f View commit details
    Browse the repository at this point in the history

  3. Use cast instead of Any 

    This isn't necessary to pass mypy, but offers a little more clarity.
    @bhrutledge
    bhrutledge committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    9a5028e View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Merge branch 'main' into fix-renderer-ignore

    @di
    di authored Mar 14, 2022
    Configuration menu
    Copy the full SHA
    0eb2280 View commit details
    Browse the repository at this point in the history