Fix renderer ignore #230
Merged
Fix renderer ignore #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on: https://mypy.readthedocs.io/en/stable/kinds_of_types.html#callable-types-and-lambdas mypy can infer lambda types; it seems we just need to annotate the lookup dict.
This isn't necessary to pass mypy, but offers a little more clarity.
bhrutledge
force-pushed
the
fix-renderer-ignore
branch
from
dd91354
to
9a5028e
Compare
miketheman
reviewed
Mar 13, 2022
Comment on lines
+8
to
+11
| show_error_codes = true | ||
| enable_error_code = [ | ||
| "ignore-without-code" | ||
| ] |
| variants = { | ||
| "GFM": lambda raw: cmarkgfm.github_flavored_markdown_to_html( | ||
| variants: Dict[str, Callable[[str], str]] = { | ||
| "GFM": lambda raw: cast(str, cmarkgfm.github_flavored_markdown_to_html( |
There was a problem hiding this comment.
Nifty trick, I'll have to remember it for the future. I've confirmed this was included in CPython since 3.5, so we're definitely safe there.
miketheman
approved these changes
Mar 13, 2022
di
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #225.
Based on: https://mypy.readthedocs.io/en/stable/kinds_of_types.html#callable-types-and-lambdas
mypy can infer lambda types; it seems we just need to annotate the lookup dict.
The
castisn't necessary to pass mypy, but offers a little more clarity.FYI @miketheman