Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow older setuptools_scm versions when building #1208

Merged
merged 1 commit into from
Jan 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/1208.bugfix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Support building pipx wheels with setuptools-scm<7, such as on FreeBSD.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -84,5 +84,5 @@ issue_format = "[#{issue}](https://github.com/pypa/pipx/issues/{issue})"
package = "pipx"

[[tool.mypy.overrides]]
module = ["pipx.version", "pycowsay.*"]
module = ["pycowsay.*"]
ignore_missing_imports = true
2 changes: 1 addition & 1 deletion src/pipx/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
from pipx.interpreter import DEFAULT_PYTHON, InterpreterResolutionError, find_python_interpreter
from pipx.util import PipxError, mkdir, pipx_wrap, rmdir
from pipx.venv import VenvContainer
from pipx.version import __version__
from pipx.version import version as __version__

logger = logging.getLogger(__name__)

Expand Down
5 changes: 5 additions & 0 deletions src/pipx/version.pyi
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
version: str
version_tuple: tuple[int, int, int, str, str] | tuple[int, int, int]

# Note that newer versions of setuptools_scm also add __version__, but we are
# not forcing new versions of setuptools_scm, so only these imports are allowed.