Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow older setuptools_scm versions when building #1208

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Jan 15, 2024

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Fixes #1207, supports older versions of setuptools_scm, not just 7+.

Summary of changes

This uses version.py's version attribute, which was present since the beginning, not the __version__ alias that was added in version 7.

This also adds a version.pyi file, allowing mypy to check this, and removes the ignore that was needed when that file was missing.

Test plan

Tested in CI.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 3817a0e into pypa:main Jan 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old setuptools_scm issue (FreeBSD, for example)
2 participants