Skip to content

Conversation

matteius
Copy link
Member

@matteius matteius commented Aug 26, 2023

Fix sys_platform specifiers (which are in our docs) being ignored from the Pipfile.

The issue

Fixes #5785
Fixes #5844

The fix

How does this pull request fix your problem? Did you consider any alternatives? Why is this the best solution, in your opinion?

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

Base automatically changed from file-installs-take3 to main August 26, 2023 12:54
@matteius matteius marked this pull request as ready for review August 26, 2023 13:21
@matteius matteius changed the title Fix not considering sys platform markers from Pipfile Fix for sys platform markers from Pipfile + fix for vcs subdirectory fragments Aug 26, 2023
@matteius matteius requested a review from oz123 August 26, 2023 13:26
@matteius matteius merged commit 08c14e9 into main Aug 26, 2023
@matteius matteius deleted the sys_platform-fix branch August 26, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doesn't create a subdirectory with "pipenv requirements" command Platform specific installs are not respected when using file with a url

1 participant