Doesn't create a subdirectory with "pipenv requirements" command

[Azaze1l]

Issue description

Hello!

I'm having a problem generating requirements.txt based on Pipfile.lock file.

Dummy sample of Pipfile.lock with problem package:

"my_shiny_custom_package": {
            "git": "https://${GITHUB_ACCESS_TOKEN}@github.com/custom-python-packages.git",
            "ref": "123451234512345123451234512351234513245",
            "subdirectory": "src/my_shiny_custom_package"
},

You can see the expected and actual results of running pipenv requirements > requirements.txt below

Expected result

Sample of requirements.txt:

my_shiny_custom_package @ git+https://${GITHUB_ACCESS_TOKEN}@github.com/custom-python-packages.git@123451234512345123451234512351234513245#subdirectory=src/my_shiny_custom_package

Actual result

Sample of requirements.txt:

my_shiny_custom_package @ git+https://${GITHUB_ACCESS_TOKEN}@github.com/custom-python-packages.git@123451234512345123451234512351234513245

[matteius]

Thanks for this report -- it should be possible to fix this in the new code paths.

[matteius]

@Azaze1l Can you tell me if you re-lock does the sub-directory fragment remain? I need to know if there are two things to fix or just one.

[Azaze1l]

@matteius, shure!

I've updated to the 2023.8.21 version and run pipenv lock

As a result I've got package declaration without sub-directory fragment:

        "my_shiny_custom_package": {
            "git": "https://${GITHUB_ACCESS_TOKEN}@github.com/custom-python-packages.git",
            "ref": "123451234512345123451234512351234513245"
        },

[Azaze1l]

Also, package declaration in Pipfile looks like this:

[packages]
my_shiny_custom_package = { subdirectory = "src/my_shiny_custom_package", ref = "release-v1.0.0", git = "https://${GITHUB_ACCESS_TOKEN}@github.com/custom-python-packages.git" }

[matteius]

Thanks for the added details -- will be helpful towards patching it.

[omelia-iliffe]

I'm having a similar issue and its causing pip sync to fail as it cannot find a setup.py or pyproject.toml

Pipfile.lock

        "dynamixel-sdk": {
            "git": "https://github.com/omelia-wetaworkshop/DynamixelSDK",
            "ref": "46ba665b7fb44f039c503e902803b963270c9ff5",
            "subdirectory": "python"
        },

pipenv sync log:

[pipenv.exceptions.InstallError]: Collecting dynamixel-sdk@ git+https://github.com/omelia-wetaworkshop/DynamixelSDK@46ba665b7fb44f039c503e902803b963270c9ff5 (from -r /tmp/pipenv-e2bzah8p-requirements/pipenv-wpfdjomw-reqs.txt (line 1))
[pipenv.exceptions.InstallError]:   Cloning https://github.com/omelia-wetaworkshop/DynamixelSDK (to revision 46ba665b7fb44f039c503e902803b963270c9ff5) to /tmp/pip-install-_j_5jfni/dynamixel-sdk_aae0390a392f4d50b8ca60ce916a9659
[pipenv.exceptions.InstallError]:   Resolved https://github.com/omelia-wetaworkshop/DynamixelSDK to commit 46ba665b7fb44f039c503e902803b963270c9ff5
[pipenv.exceptions.InstallError]: Running command git clone --filter=blob:none --quiet https://github.com/omelia-wetaworkshop/DynamixelSDK /tmp/pip-install-_j_5jfni/dynamixel-sdk_aae0390a392f4d50b8ca60ce916a9659
[pipenv.exceptions.InstallError]:   Running command git rev-parse -q --verify 'sha^46ba665b7fb44f039c503e902803b963270c9ff5'
[pipenv.exceptions.InstallError]:   Running command git fetch -q https://github.com/omelia-wetaworkshop/DynamixelSDK 46ba665b7fb44f039c503e902803b963270c9ff5
[pipenv.exceptions.InstallError]:   Running command git checkout -q 46ba665b7fb44f039c503e902803b963270c9ff5
[pipenv.exceptions.InstallError]: ERROR: dynamixel-sdk@ git+https://github.com/omelia-wetaworkshop/DynamixelSDK@46ba665b7fb44f039c503e902803b963270c9ff5 from git+https://github.com/omelia-wetaworkshop/DynamixelSDK@46ba665b7fb44f039c503e902803b963270c9ff5 (from -r /tmp/pipenv-e2bzah8p-requirements/pipenv-wpfdjomw-reqs.txt (line 1)) does not appear to be a Python project: neither 'setup.py' nor 'pyproject.toml' found.

Downgraded to 2023.7.23 and it syncs without errors