-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed editable package with markers can not be locked #2903
Fixed editable package with markers can not be locked #2903
Conversation
I think this can be closed? We upgrade vendor packages before release. The fix in RequirementsLib will be included by the automated script, so you don’t need to do this manually. |
No problem. But how about the added tests? It will be nice to have tests which can make sure that later development won't break any current working cases |
I’d be fine if there is a test to ensure |
fb21bb1
to
6207fec
Compare
Great. I've udpated the PR which removed the requirementslib patch as well as the news (since the test is too trivial) Currently the CI would be broken but it should be fine after sarugaku/requirementslib#71 is merged from upstream. |
I’ll release requirementslib in the next few days when I am sure we captured everything |
6207fec
to
6525e31
Compare
Update: it's ready for merge since #2935 has been merged |
The issue
Fixed #2902 and also added tests. Without this patch, the new added test will fail.
The fix
Fixed in upstream sarugaku/requirementslib#71. If it can be accepted in upstream, then it can be merged here.
The checklist
news/
directory to describe this fix with the extension.bugfix
,.feature
,.behavior
,.doc
..vendor
. or.trivial
(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.