Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pip piptools #2935

Merged
merged 35 commits into from
Oct 8, 2018
Merged

Update pip piptools #2935

merged 35 commits into from
Oct 8, 2018

Conversation

techalchemy
Copy link
Member

Update vendored dependencies, updae pip, update piptools, fix all tests, fixx all broken patches, prep for release.

In addition I manually tested the resolver against the following outstanding resolution issues given the nondeterministic nature in the previous release -- this should be a substantial improvement.

Remaining changes should focus on VCS dependencies (see #1393)

@techalchemy
Vendor passa as zip for running in venvs
320f216 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Add passa to vendoring task
a698fee 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Vendor passa, update piptools
1af729f 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Vendor yaspin, update vistir, add pip18 patch
8811b69 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Remove pip10 patch
21eb04a 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Update vistir vendoring
949a671 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Fix passa dep
7784f64 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
update patch for piptools
7bc29c1 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
fix pip patch
42eed8a 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Update passa
b2957af 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Update to pip 18
6c2db69 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Import rewrites
9fce94b 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Fix passa vendoring task
4a5b63a 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Update vendored dependencies
c257891 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Update all vendored dependencies
ad2d6c9 
- Verified all license changes
- Brings us current with the latest releases
- Didn't identify any breaking changes in click

Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Re-updated pip patch to ignore compatibility when sorting
0f9ce3e 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Patch pipdeptree
121390d 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Update pip_shims
17e73f5 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Add deprecation warning ignores to pytest.ini
3f8824f 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Update pip_shims self-import module replacement logic with new names
6c8ad87 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
update vendored shims version
339c50e 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Add a proper parser for index urls internally
7429881 
- Fix invocation of vcs hash retrieval
- Add error handling for pip url retrieval

Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
fix piptools patch to account for None in hash lookups
6e042b3 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Remove extra piptools license
71ed413 
- Fixes 2678

Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Add news fragments and final patch for all fixes
bf64e7b 
- Fixes #2499
- Fixes #2529
- Fixes #2589
- Fixes #2666
- Fixes #2767
- Fixes #2785
- Fixes #2795
- Fixes #2801
- Fixes #2802
- Fixes #2824
- Fixes #2862
- Fixes #2867
- Fixes #2879
- Fixes #2880
- Fixes #2894
- Fixes #2902
- Fixes #2924

Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy added Type: Enhancement 💡 This is a feature or enhancement request. Category: Dependency Resolution Issue relates to dependency resolution. Category: Tests Relates to tests. Type: Vendored Dependencies This issue affects vendored dependencies within pipenv. labels Oct 7, 2018
@techalchemy
Fix manifest
c3303d5 
Signed-off-by: Dan Ryan <dan@danryan.co>
@jxltom jxltom mentioned this pull request Oct 7, 2018
Closed
@techalchemy techalchemy mentioned this pull request Oct 7, 2018
Closed
@techalchemy
Fix environment variable encoding for python 2
1605c00 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
move environment imports local so we can use fs_str in env declarations
1000bdc 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Clean up redundant code and avoid circular imports
734b4e7 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Expose fs_str in utils.py
2590c4c 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Update piptools patches
3a303ee 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Fix pipdeptree patch
b58f902 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Fix pipdeptree patch again
d289e46 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Update piptools and fix patch
16fb2d1 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
cast environment var as string
6136edc 
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy merged commit 21e9e24 into master Oct 8, 2018
@techalchemy techalchemy deleted the update-pip-piptools branch October 8, 2018 05:09
@jxltom jxltom mentioned this pull request Oct 8, 2018
Closed
2 tasks
Closed
@yoonjechoi
Copy link

When will a new version that contains this pull request be release?
When will it be released to pypi, too?

@gsemet
Copy link
Contributor

gsemet commented Oct 8, 2018

You need to freeze to pip 18.0 for the time being.

@browniebroke browniebroke mentioned this pull request Oct 8, 2018
Closed
This was referenced Oct 9, 2018
Merged
Merged
Closed
Closed
@yoonjechoi
Copy link

yoonjechoi commented Oct 9, 2018 •
edited
Loading

FYI. How to work around ( use pip 18.0 )
If you're using pip 18.1, install 18.0 with following command.
pip install --upgrade pip==18.0

@techalchemy
Copy link
Member Author

We will be updating on pypi tonight or tomorrow (I have a small UI change that will need Kenneth to sign off on)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uranusjr uranusjr Awaiting requested review from uranusjr

Assignees
No one assigned
Labels
Category: Dependency Resolution Issue relates to dependency resolution. Category: Tests Relates to tests. Type: Enhancement 💡 This is a feature or enhancement request. Type: Vendored Dependencies This issue affects vendored dependencies within pipenv.
Projects
None yet
Milestone
No milestone
3 participants
@techalchemy @yoonjechoi @gsemet