Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove typing.TYPE_CHECKING guards #9424

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Remove typing.TYPE_CHECKING guards #9424

merged 1 commit into from
Feb 20, 2021

Conversation

jdufresne
Copy link
Contributor

The typing module has been available since Python 3.5. Guarding the
import has been unnecessary since dropping Python 2.

Some guards remain to either:

  • Avoid circular imports
  • Importing objects that are also guarded by typing.TYPE_CHECKING
  • Avoid mypy_extensions dependency

@jdufresne jdufresne mentioned this pull request Jan 3, 2021
Merged
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 4, 2021
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 19, 2021
@jdufresne
Copy link
Contributor Author

Rebased

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 19, 2021
@jdufresne
Remove typing.TYPE_CHECKING guards
0945809 
The typing module has been available since Python 3.5. Guarding the
import has been unnecessary since dropping Python 2.

Some guards remain to either:

- Avoid circular imports
- Importing objects that are also guarded by typing.TYPE_CHECKING
- Avoid mypy_extensions dependency
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 20, 2021
pradyunsg
pradyunsg approved these changes Feb 20, 2021
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one’s looooong. Let’s merge it before we get more conflicts.

@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Feb 20, 2021
@pradyunsg pradyunsg merged commit 25114e1 into pypa:master Feb 20, 2021
@jdufresne jdufresne deleted the typing-no-guard branch February 20, 2021 13:20
@pfmoore pfmoore mentioned this pull request Apr 24, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdufresne @BrownTruck @pradyunsg @pypa-bot