Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum Python version for 21.1 is 3.6.2 #9831

Closed
philthompson10 opened this issue Apr 24, 2021 · 3 comments · Fixed by #9835
Closed

Minimum Python version for 21.1 is 3.6.2 #9831

philthompson10 opened this issue Apr 24, 2021 · 3 comments · Fixed by #9835

Comments

@philthompson10
Copy link

Because of the use of typing.NoReturn I think the minimum Python version for 21.1 should be 3.6.2 rather than just 3.6.

Phil
@pfmoore
Copy link
Member

pfmoore commented Apr 24, 2021

If typing added a name in 3.6.2, that sounds like a breaking change that probably shouldn't have been allowed by CPython 🙁

This appears to have been introduced in #9424. We used NoReturn before that, but it was guarded by if TYPE_CHECKING, so didn't affect runtime behaviour.

@jamescurtin jamescurtin mentioned this issue Apr 24, 2021
Merged
@jamescurtin
Copy link
Contributor

👋 I put up a PR to resolve this. As I am a first-time contributor, could a maintainer please unblock the CI?
image

Thank you!

@pfmoore
Copy link
Member

pfmoore commented Apr 24, 2021

that sounds like a breaking change that probably shouldn't have been allowed by CPython

Actually the typing library is provisional in 3.6, so this is allowable. We probably shouldn't have been quite so quick to remove the if TYPE_CHECKING guards...

@sbidoul sbidoul mentioned this issue Apr 26, 2021
Closed
1 task
@sergiitk sergiitk mentioned this issue Apr 26, 2021
Merged
@pfmoore pfmoore mentioned this issue Apr 26, 2021
Closed
1 task
simon-mo added a commit to simon-mo/ray that referenced this issue Apr 26, 2021
@simon-mo
Wheel Build macOS Python 3.6: 3.6.1 -> 3.6.2
b9a64b7 
To circumvent the pip issue
pypa/pip#9831
@simon-mo simon-mo mentioned this issue Apr 26, 2021
Merged
6 tasks
@sergiitk sergiitk mentioned this issue Apr 26, 2021
Merged
simon-mo added a commit to ray-project/ray that referenced this issue Apr 26, 2021
@simon-mo
Wheel Build macOS Python 3.6: 3.6.1 -> 3.6.2 (#15519)
6504c05 
To circumvent the pip issue
pypa/pip#9831
@esc esc mentioned this issue Apr 27, 2021
Merged
@pfmoore pfmoore mentioned this issue Apr 27, 2021
Closed
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix import error introduced in 21.1 jamescurtin/pip
3 participants
@pfmoore @jamescurtin @philthompson10