Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround CI failures due to "pip search" throttling #9051

Merged
merged 4 commits into from
Oct 26, 2020
Merged

Workaround CI failures due to "pip search" throttling #9051

merged 4 commits into from
Oct 26, 2020

Conversation

pradyunsg
Copy link
Member

Toward #9030

@pradyunsg pradyunsg added C: tests Testing and related things C: automation Automated checks, CI etc labels Oct 25, 2020
@pradyunsg pradyunsg mentioned this pull request Oct 25, 2020
Closed
@pradyunsg
Move build_env tests to functional
abb3d0f 
These tests use the script fixture which as a 30s setup time on my
machine. This KILLS productivity when trying to run unit tests as part
of a feedback loop during development.
@pradyunsg
Copy link
Member Author

Cool, this works for the pip search rate limits.

@pradyunsg pradyunsg changed the title Fix CI "pip search" throttling issues Workaround CI failures ("pip search" throttling + build_env errors on Azure's MacOS VM) Oct 25, 2020
@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Oct 25, 2020
@pradyunsg
Copy link
Member Author

Skipping the failing tests is fine, right? :)

@pradyunsg pradyunsg marked this pull request as ready for review October 25, 2020 18:13
@hugovk
Copy link
Contributor

hugovk commented Oct 25, 2020

If you don't want to add a new env var, Azure Pipelines has a TF_BUILD var set to true.

https://docs.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml#system-variables-devops-services

It's less obvious what it's for though. This is how we used it at Pillow (but we've since dropped Azure Pipelines): python-pillow/Pillow#4074

@pradyunsg
Copy link
Member Author

I'mma head to bed, so let's hope the CI passes. If it does, please feel free to merge if no one raises concerns. :)

@pradyunsg
Copy link
Member Author

If you don't want to add a new env var

I think it's fine, since we have CI set automatically by GitHub Actions and Travis CI.

@pradyunsg
Copy link
Member Author

Looks like the issue is deeper, with the failure on Azure+MacOS originating from the use of the script fixture, AKA Python + virtualenv 16. :(

@pradyunsg
Copy link
Member Author

I'm gonna drop from 7669d84 from this. The rest is A-OK to force-merge IMO (since it fixes the pip search issue). IMO we should tackle the Azure MacOS issue separately.

@pradyunsg pradyunsg changed the title Workaround CI failures ("pip search" throttling + build_env errors on Azure's MacOS VM) Workaround CI failures due to "pip search" throttling Oct 25, 2020
@pradyunsg pradyunsg merged commit cffc3a6 into pypa:master Oct 26, 2020
@pradyunsg pradyunsg mentioned this pull request Oct 26, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
C: automation Automated checks, CI etc C: tests Testing and related things skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pradyunsg @hugovk