Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ImageShow.show on CIs #4074

Merged
merged 1 commit into from
Sep 21, 2019
Merged

Conversation

radarhere
Copy link
Member

This PR adds a test that actually runs the ImageShow.show method, opening the image. However, to be neat, it only runs on the CIs, where the shown images won't bother users.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also run it on Azure Pipelines?

CI env vars
AppVeyor CI, APPVEYOR
Azure Pipelines TF_BUILD
Travis CI CI, CONTINUOUS_INTEGRATION, TRAVIS

There's no similar env var for GitHub Actions yet, it's been requested here:

Perhaps add an on_ci() that checks for CI and TF_BUILD? Then if GHA adds CI it'll be covered.

@radarhere
Copy link
Member Author

Okay, done.

@hugovk hugovk merged commit 0c07e99 into python-pillow:master Sep 21, 2019
@radarhere radarhere deleted the imageshow_test branch September 21, 2019 13:23
@nulano
Copy link
Contributor

nulano commented Sep 24, 2019

Note, that on Windows this will always either succeed (AppVeyor), or hang (GitHub Actions). It can't fail, even if there is no application associated with the file format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants