Move ui helpers to cli subpackage #6727

sinscary · 2019-07-18T06:08:33Z

Separated spinners and progress_bars to separate modules
Moved these modules under pip._internal.cli.*

pradyunsg · 2019-07-18T10:08:27Z

tests/unit/test_utils.py

@@ -38,7 +38,7 @@
 )
 from pip._internal.utils.setuptools_build import make_setuptools_shim_args
 from pip._internal.utils.temp_dir import AdjacentTempDirectory, TempDirectory
-from pip._internal.utils.ui import SpinnerInterface
+from pip._internal.cli.spinners import SpinnerInterface


Tests for this should probably move into a test_cli_spinners.py file. :)

Sure will do that.

pradyunsg · 2019-07-18T10:10:39Z

Thanks for your work here @sinscary! :D

I won't be able to review this thoroughly right now; working on #6630 for at least this week.

pradyunsg · 2019-07-20T04:38:13Z

@sinscary could you update this PR (merge or rebase)?

BrownTruck · 2019-07-20T06:45:05Z

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

BrownTruck · 2019-08-05T10:15:07Z

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

BrownTruck · 2019-09-28T23:30:05Z

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

uranusjr · 2020-01-07T08:07:25Z

Hi @sinscary would you mind clean up the commits a bit, and rebase it onto master so this can be merged? The changes themselves LGTM so a cleanup would be all that’s needed for this to be merged.

sinscary · 2020-01-07T08:27:50Z

@uranusjr @pradyunsg Man I got busy with some work and forgot about this PR. Sure I will clean this up during the weekend.

pradyunsg · 2020-01-27T14:03:52Z

@sinscary If you have any questions / need help here, please let us know. :)

sinscary · 2020-01-27T17:40:57Z

@pradyunsg Apart from linter errors(that I will take care of) there is this one test case(test_pep517_and_build_options) which is continously failing. A little help will really speed up the things. :)

sinscary · 2020-01-28T13:04:27Z

@pradyunsg This time integration tests passed for all the platforms and versions except python27 windows. As I can see this is failing for most who have created PR today or yesterday.

pradyunsg · 2020-01-28T13:10:27Z

This time integration tests passed for all the platforms and versions except python27 windows. As I can see this is failing for most who have created PR today or yesterday.

Yea, looks like something's up -- I'll take a closer look. :)

pfmoore · 2020-01-28T13:54:39Z

See #7662 (comment)

BrownTruck · 2020-02-02T05:15:01Z

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

sinscary · 2020-02-20T05:48:53Z

@pradyunsg mypy check is failing for InterruptibleMixin inside progeress_bars.py, which led me to this issue . All the mixins are having this issue. Not really sure how to approach this.

This reverts commit d1ca99ccc05075d8d4ae101a3f10b003086ebeda.

sinscary · 2020-02-21T05:22:25Z

@pradyunsg I have marked mixins to be ignored for now. Can you once review PR.

pradyunsg

@sinscary Thanks for the ping (and your patience here!). I like the way you've made your commits which made it super easy to review this PR!

Overall, this LGTM. I'm OK to merge this as is, albeit with a tracking issue for dropping the # type: ignore comments.

We should drop the # type: ignore comments and instead add something like the following to the top of the file:

# The following comment should be removed at some point in the future.
# mypy: strict-optional=False

AFAICT, that should fix almost all the mypy issues you're facing here. If you want to try that and fix any remaining mypy issues, lemme know. Otherwise, I'll be happy to pick things up from here, if you don't want to deal with mypy issues. :)

sinscary · 2020-02-21T07:13:50Z

@pradyunsg Currently the issues I am facing with mixins won't be fixed by disabling strict optional checking, I tried that and mypy check failing with same errors. I really wanna pickup something new.

pradyunsg · 2020-02-21T08:32:36Z

Sure thing @sinscary! Thanks again for the PR! Lemme know if you'd like me to suggest another issue for you to work on. :)

sinscary · 2020-02-21T09:43:19Z

@pradyunsg Sure.

pradyunsg · 2020-02-21T15:27:03Z

@sinscary #7249. :)

sinscary changed the title ~~Move cli helpers to cli subpackage~~ Move ui helpers to cli subpackage Jul 18, 2019

pradyunsg reviewed Jul 18, 2019

View reviewed changes

pradyunsg added the type: refactor Refactoring code label Jul 18, 2019

BrownTruck added the needs rebase or merge PR has conflicts with current master label Jul 20, 2019

sinscary force-pushed the move_cli_helpers_to_cli_subpackage branch from c3253ad to e3a4d5d Compare July 24, 2019 11:52

pypa-bot removed the needs rebase or merge PR has conflicts with current master label Jul 24, 2019

sinscary force-pushed the move_cli_helpers_to_cli_subpackage branch from e3a4d5d to 9cb49c8 Compare July 25, 2019 05:02

BrownTruck added the needs rebase or merge PR has conflicts with current master label Aug 5, 2019

sinscary force-pushed the move_cli_helpers_to_cli_subpackage branch from 9cb49c8 to 59c1108 Compare September 27, 2019 04:58

pypa-bot removed the needs rebase or merge PR has conflicts with current master label Sep 27, 2019

BrownTruck added the needs rebase or merge PR has conflicts with current master label Sep 28, 2019

pradyunsg added the S: awaiting response Waiting for a response/more information label Jan 7, 2020

sinscary force-pushed the move_cli_helpers_to_cli_subpackage branch from 59c1108 to ffd8274 Compare January 7, 2020 11:09

pypa-bot removed the needs rebase or merge PR has conflicts with current master label Jan 7, 2020

pradyunsg removed the S: awaiting response Waiting for a response/more information label Jan 10, 2020

sinscary force-pushed the move_cli_helpers_to_cli_subpackage branch from ffd8274 to 9956ee0 Compare January 27, 2020 12:16

pradyunsg mentioned this pull request Jan 29, 2020

Windows CI is currently broken for Python 2.7 #7671

Closed

sinscary added 14 commits February 20, 2020 15:42

move ui.py into cli subpackage

de2d567

move spinners to separate module

5bae6fd

move progress_bars helpers to separate module

160c34a

Revert "move ui.py into cli subpackage"

9143bce

This reverts commit d1ca99ccc05075d8d4ae101a3f10b003086ebeda.

add only required imports to spinners and progress bar

7c172c2

add imports for spinners and progress bar from their own module

68c750b

remove ui.py helper file

b6bcc96

Add trivial news file for code refactor

5cf4e95

fix linter errors

e282c1a

sort imports and rebase with upstream

cd4dd7d

change spinner imports for new files and rebase

f161d73

remove unnecessary imports for spinners

c2f5c37

import subprocess from updated path and rebase

b7f3c40

add mypy annotations for progress_bars and spinners

fe1d58b

sinscary force-pushed the move_cli_helpers_to_cli_subpackage branch 3 times, most recently from 71f9b28 to 182b73b Compare February 20, 2020 10:56

fix mypy and linter errors for spinners and progressbars

30933a0

sinscary force-pushed the move_cli_helpers_to_cli_subpackage branch from 182b73b to 30933a0 Compare February 20, 2020 10:59

pradyunsg approved these changes Feb 21, 2020

View reviewed changes

pradyunsg merged commit ce1e0f4 into pypa:master Feb 21, 2020

pradyunsg mentioned this pull request Feb 21, 2020

Drop # type: ignore comments in cli subpackage #7764

Closed

lock bot added the auto-locked Outdated issues that have been locked by automation label Mar 22, 2020

lock bot locked as resolved and limited conversation to collaborators Mar 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move ui helpers to cli subpackage #6727

Move ui helpers to cli subpackage #6727

sinscary commented Jul 18, 2019

pradyunsg Jul 18, 2019

sinscary Jul 18, 2019

pradyunsg commented Jul 18, 2019

pradyunsg commented Jul 20, 2019

BrownTruck commented Jul 20, 2019

BrownTruck commented Aug 5, 2019

BrownTruck commented Sep 28, 2019

uranusjr commented Jan 7, 2020

sinscary commented Jan 7, 2020

pradyunsg commented Jan 27, 2020

sinscary commented Jan 27, 2020

sinscary commented Jan 28, 2020

pradyunsg commented Jan 28, 2020

pfmoore commented Jan 28, 2020

BrownTruck commented Feb 2, 2020

sinscary commented Feb 20, 2020 •

edited

Loading

sinscary commented Feb 21, 2020

pradyunsg left a comment

sinscary commented Feb 21, 2020 •

edited

Loading

pradyunsg commented Feb 21, 2020

sinscary commented Feb 21, 2020

pradyunsg commented Feb 21, 2020

Move ui helpers to cli subpackage #6727

Move ui helpers to cli subpackage #6727

Conversation

sinscary commented Jul 18, 2019

pradyunsg Jul 18, 2019

Choose a reason for hiding this comment

sinscary Jul 18, 2019

Choose a reason for hiding this comment

pradyunsg commented Jul 18, 2019

pradyunsg commented Jul 20, 2019

BrownTruck commented Jul 20, 2019

BrownTruck commented Aug 5, 2019

BrownTruck commented Sep 28, 2019

uranusjr commented Jan 7, 2020

sinscary commented Jan 7, 2020

pradyunsg commented Jan 27, 2020

sinscary commented Jan 27, 2020

sinscary commented Jan 28, 2020

pradyunsg commented Jan 28, 2020

pfmoore commented Jan 28, 2020

BrownTruck commented Feb 2, 2020

sinscary commented Feb 20, 2020 • edited Loading

sinscary commented Feb 21, 2020

pradyunsg left a comment

Choose a reason for hiding this comment

sinscary commented Feb 21, 2020 • edited Loading

pradyunsg commented Feb 21, 2020

sinscary commented Feb 21, 2020

pradyunsg commented Feb 21, 2020

sinscary commented Feb 20, 2020 •

edited

Loading

sinscary commented Feb 21, 2020 •

edited

Loading