-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop # type: ignore
comments in cli subpackage
#7764
Comments
Hello @pradyunsg, I would like to work on this issue. Could you please assign this to me? |
@mathagician Sure! Go ahead! :) Note that this issue will entail fixing the mypy issues, that are being silenced by the ignore comments. |
Hey @mathagician let me know if you are still working on this, I'd like to work on it as well 😄 @pradyunsg I'm not sure how I can reproduce the mypy issues in cli subpackage. I ran the command
|
@rohitsanj please post the entire output, otherwise it is not possible to get the required context to help answer your questions. |
Hi @pradyunsg Can I take up this PR? Also what is the fix you are looking for the PR here? Is the aim to remove all |
Yea, basically. :) |
I was experimenting a bit, and found that if InterruptibleMixin But I am not sure this is the correct way, and if it defeats the purpose of defining these classes as Mixin. |
Follow up on #6727 (review)
The text was updated successfully, but these errors were encountered: