Decouple logs output color from the logging level

[healthy-pod]

Previously, each logging level was coupled with a specific
output color. This isn't always ideal because we might need
to log at a certain level but use a custom color (based on
user feedback / see linked issue).

This patch decouples the logs output color from the logging
level.

Fixes #10519

[pradyunsg]

Hurrah! Work for #10421 is making these little things easier as well!

[healthy-pod]

Fixed (at least I think I did) a pre-commit issue in the last change. It's my first contribution to pip so feel free to let me know if there's anything I need to update!

[DiddiLeija]

The linters are going well. The tests are currently failing because of #10742.

[pradyunsg]

Doing the close-reopen dance, in case GH actions runs on a simulated merge commit.

[webknjaz]

@healthy-pod why did you add a "bugfix" change note? This seems to be a feature. Also, is the note text empty by accident?

On a side note: it may be worth splitting the addition of the mechanism that implements attaching colors to messages and using it. I'd imagine that the first part could benefit from some sort of automatic tests.

P.S. I see you're allowing color strings — would allowing to set the whole style too be useful?

[pradyunsg]

Hiya @healthy-pod! Could you rebase¹ this PR?

This branch was created at a point where the CI on main was broken, and thus, can't be merged as-is.

Footnotes

1. If you're not familiar with this, you might find this article to be a useful read. :) ↩

[healthy-pod]

Hiya @healthy-pod! Could you rebase1 this PR?

This branch was created at a point where the CI on main was broken, and thus, can't be merged as-is.

Done

[pradyunsg]

I swear our CI is usually not a fickle beast like this. Ok, maybe it is...

Anyway, @healthy-pod could you rebase this again?

[healthy-pod]

Anyway, @healthy-pod could you rebase this again?

Done

[pradyunsg]

Oh hey, look! The test suite works, and there's tests that caught that you're spewing to stderr instead of stdout now. You'll likely need to fix those! :)

[pradyunsg]

Hiya @healthy-pod! A gentle nudge on this -- this PR needs a minro update. If you won't have time to address this soon, please let me know and I'll pick it up. :)

[healthy-pod]

Hiya @healthy-pod! A gentle nudge on this -- this PR needs a minro update. If you won't have time to address this soon, please let me know and I'll pick it up. :)

Thanks for the reminder @pradyunsg! I assume "critical" goes to stderr while "info" goes to stdout. I changed logger.info to logger.critical in factory.py which caused some tests expecting some output at stdout to get it at stderr. Is my analysis correct? If so, do we want to change the tests in this case (ie change what they expect)? I wonder what the tests did when the line I changed was originally logger.critical (ie before it was even changed to logger.info).