manylinux1_x86_64: Try to not install i686/i386 #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
added a commit
to dockbuild/dockbuild
that referenced
this pull request
Mar 3, 2018
…rom centos:5 The differences between the two images are in the build.sh script, They have been marked with comment block starting with "[centosbuild]" and ending with "[/centosbuild]". Remaining changes have been contributed upstream: pypa/manylinux#161 pypa/manylinux#162 See https://github.com/pypa/manylinux
|
What does this do? Why did you need it? |
|
It decreases the size of the x86_64 image by not installing the i686/i386 packages. Since I re-used the script of manylinux in a different context, I thought it would make sense to contribute this optimization. |
|
@njsmith @matthew-brett Anything I could do move this forward ? Thanks for your review and feedback. |
|
We can't really merge anything until openssl is fixed – right now the build would just fail anyway if we did. |
|
Travis is doing something weird here, going to try to close/reopen and see if that fixes it. |
jcfr
force-pushed
the
optimize-size-x86_64-image
branch
from
b651dc9 to
b81baf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.