Build scripts cleanup #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
added a commit
to dockbuild/dockbuild
that referenced
this pull request
Mar 3, 2018
…rom centos:5 The differences between the two images are in the build.sh script, They have been marked with comment block starting with "[centosbuild]" and ending with "[/centosbuild]". Remaining changes have been contributed upstream: pypa/manylinux#161 pypa/manylinux#162 See https://github.com/pypa/manylinux
|
@njsmith In addition of few aesthetic cleanups, this PR has also the advantage of removing the curl It is ready to be merged. |
|
@njsmith @matthew-brett What is the process to get this integrated ? |
|
Are the changes here still correct now that #174 was merged? (They both have some mention of curl...) |
gettext and expat-devel are already listed in PYTHON_COMPILE_DEPS
jcfr
force-pushed
the
build-scripts-cleanup
branch
from
3147d5d to
24fc42d
Compare
Indeed. Topic was rebased and CI is green. |
|
With the switch back to the canonical archive, the old The rest looks 👍 to me. |
jcfr
force-pushed
the
build-scripts-cleanup
branch
from
24fc42d to
8efa4ef
Compare
Indeed 👍 Updated topic pushed (from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.