-
Notifications
You must be signed in to change notification settings - Fork 294
fix: always expose uv in PATH
#2691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
It's might be used for Android
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Android change looks OK to me, but I don't know enough to comment on the larger question of this PR vs #2690.
|
Build should behave similarly, using a uv in the path if there's no |
If cibuildwheel's I see you opened an issue in build and that's probably a good thing which should be applied ecosystem wide and would allow for an easier resolution. |
|
Hmm. All this is starting to feel a little messy/hacky. I'm thinking there's another option here, where we say that if the build-frontend uses In the case of the github action, we could just use astral/setup-uv conditionally, and keep the direct invocation there? As I see it, the |
This PR changes the way
uvis used in cibuildwheel for direct invocations.At the moment, there's a mixed usage of direct invocations (assumed in
PATH) &find_uv()path invocations.#2690 has been opened to always use
find_uv()but this is not really compatible withbuildunless it's installed with theuvextra.In order not to install
build'suvextra,find_uvis updated to symlink/copyuvin a temporary directory. This temporary directory is added to build/test virtual environmentsPATHwhich removes the need to installbuild'suvextra when usingcibuildwheel'suvextra.close #2690
close #2673