Override leaky env vars #406
Conversation
"build" is the name of the package.
* `IsolatedEnv` reworked to subsume env creation logic. * `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. * `ProjectBuilder.from_isolated_env` added to auto-fill init args from an isolated env. * Made `IsolatedEnv` responsible for customising the environ as a prelude to fixing pypa#377. Removed `ProjectBuilder.scripts_dir`. * `ProjectBuilder`'s @properties made read-only. Mutating the builder is not necessary with the addition of `ProjectBuilder.from_isolated_env`.
Fixed passing the absolutised srcdir.
…d circular imports
For example `sys.executable` would have been expanded on RTD.
This is to get annotations in `TYPE_CHECKING` blocks to show. We also mustn't import build before sphinx has a chance to.
There's three modules now which are listed on the sidebar.
This is required to resolve annotations in sphinx which are not generic at runtime (`os.PathLike`, in particular).
Also link to the correct PR.
|
Fixes #266 |
|
It fixes one particular cause of that error. I think that we should provide a better message for when pip can't be found, that's what #266 ought to fix. |
|
@layday shall we close this now, or you want to rebase it? |
Approved. |
|
Feel free to cherry-pick whatever makes sense. |
|
Seeing as #361 isn't going to be merged should this be reopened? Or am I missing what the decision is? |
|
The problem is lack of maintainer time. I was unable to review this in time, so @layday decided to close it. I hope to pick it up in the next few months. |
|
Got it, thank you! |
|
It's nothing personal, just having PRs linger fills me with a weird sort of anxiety. |
|
Whatever makes you more productive :) I just wanted to know if I should keep following along or not. |
|
We can reopen as needed, so they aren't just sitting open. :) I'm also happy to volunteer to rebase as needed. It's just @FFY00 is the most qualified to review. |
|
For anyone looking for workarounds coming from the Spack world. I install Python and all my run time dependencies using Spack but for development tools (like |
|
Spack should no longer have this issue in the latest release. I added a patch to unset |
|
Was this issue ever fixed in main or is a patch still needed? |
|
Still needed. |
|
According to #470, the recommended way to bootstrap build is to install it from a wheel. How do I patch a wheel? |
|
Or is there a way to use build to build itself? |
|
You can run build from source to build build with build. |
|
The specific bug we're facing is #266, so once #266 is solved we'll no longer need to patch. This patch was sufficient for us to solve the issue, but I'm not sure how hacky that is. It's also outdated, see spack/spack#35326 for my latest patch. |
On top of #361.