Make the API thread-safe #377
Labels
enhancement
New feature or request
Comments
|
I don't understand why we need to ditch pep517 to make the API thread-safe, can you explain? |
|
Sorry, we are not required to. If we stay with pep517, we will have to at least ditch their runners and implement a custom runner that calls our own runner API. |
|
We just have to pass some env vars I thought to the runner - all we'd have to do is make sure we're wrapping the pep517/user-provided runners. |
|
No, we need to change the runner API as the one in |
|
Actually, we can get by setting the environments we need to clear in #375 to an empty string, but it might break code that checks for the environment variable, it should be fine though. |
layday
added a commit
to layday/build
that referenced
this issue
Oct 24, 2021
The `IsolatedEnv` has been reworked to subsume env creation logic. `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. The `IsolatedEnv` takes IsolatedEnvManager` as an argument instead of passing the manager's attributes to the env piecemeal. `ProjectBuilder.from_isolated_env` has been added to auto-fill init args from an isolated env. The `ProjectBuilder`'s properties were made read-only. Mutating the builder is not necessary with the addition of `from_isolated_env`. Factored out parsing `pyproject.toml`. Fixed passing the absolute path to the srcdir validator in the project builder. Reworded `ProjectBuilder` docstrings for clarity. Moved runner logic to the isolated env as prelude to fixing pypa#377. As a consequence the runner is not replaceable when using isolation. Removed pip version detection. The default env updates pip in a subprocess.
layday
added a commit
to layday/build
that referenced
this issue
Oct 25, 2021
The `IsolatedEnv` has been reworked to subsume env creation logic. `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. The `IsolatedEnv` takes IsolatedEnvManager` as an argument instead of passing the manager's attributes to the env piecemeal. `ProjectBuilder.from_isolated_env` has been added to auto-fill init args from an isolated env. The `ProjectBuilder`'s properties were made read-only. Mutating the builder is not necessary with the addition of `from_isolated_env`. Factored out parsing `pyproject.toml`. Fixed passing the absolute path to the srcdir validator in the project builder. Reworded `ProjectBuilder` docstrings for clarity. Moved runner logic to the isolated env as prelude to fixing pypa#377. As a consequence the runner is not replaceable when using isolation. Removed pip version detection. The default env updates pip in a subprocess.
layday
added a commit
to layday/build
that referenced
this issue
Oct 25, 2021
The `IsolatedEnv` has been reworked to subsume env creation logic. `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. The `IsolatedEnv` takes IsolatedEnvManager` as an argument instead of passing the manager's attributes to the env piecemeal. `ProjectBuilder.from_isolated_env` has been added to auto-fill init args from an isolated env. The `ProjectBuilder`'s properties were made read-only. Mutating the builder is not necessary with the addition of `from_isolated_env`. Factored out parsing `pyproject.toml`. Fixed passing the absolute path to the srcdir validator in the project builder. Reworded `ProjectBuilder` docstrings for clarity. Moved runner logic to the isolated env as prelude to fixing pypa#377. As a consequence the runner is not replaceable when using isolation. Removed pip version detection. The default env updates pip in a subprocess.
layday
added a commit
to layday/build
that referenced
this issue
Oct 25, 2021
The `IsolatedEnv` has been reworked to subsume env creation logic. `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. The `IsolatedEnv` takes IsolatedEnvManager` as an argument instead of passing the manager's attributes to the env piecemeal. `ProjectBuilder.from_isolated_env` has been added to auto-fill init args from an isolated env. The `ProjectBuilder`'s properties were made read-only. Mutating the builder is not necessary with the addition of `from_isolated_env`. Reworded `ProjectBuilder` docstrings for clarity. Moved runner logic to the isolated env as prelude to fixing pypa#377. As a consequence the runner is not replaceable when using isolation. Removed pip version detection. The default env updates pip in a subprocess.
layday
added a commit
to layday/build
that referenced
this issue
Oct 28, 2021
The `IsolatedEnv` has been reworked to subsume env creation logic. `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. The `IsolatedEnv` takes IsolatedEnvManager` as an argument instead of passing the manager's attributes to the env piecemeal. `ProjectBuilder.from_isolated_env` has been added to auto-fill init args from an isolated env. The `ProjectBuilder`'s properties were made read-only. Mutating the builder is not necessary with the addition of `from_isolated_env`. Moved runner logic to the isolated env as prelude to fixing pypa#377. As a consequence the runner is not replaceable when using isolation. Removed pip version detection. The default env updates pip in a subprocess.
layday
added a commit
to layday/build
that referenced
this issue
Oct 28, 2021
The `IsolatedEnv` has been reworked to subsume env creation logic. `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. The `IsolatedEnv` takes IsolatedEnvManager` as an argument instead of passing the manager's attributes to the env piecemeal. `ProjectBuilder.from_isolated_env` has been added to auto-fill init args from an isolated env. The `ProjectBuilder`'s properties were made read-only. Mutating the builder is not necessary with the addition of `from_isolated_env`. Moved runner logic to the isolated env as prelude to fixing pypa#377. As a consequence the runner is not replaceable when using isolation. Removed pip version detection. The default env updates pip in a subprocess.
layday
added a commit
to layday/build
that referenced
this issue
Oct 28, 2021
The `IsolatedEnv` has been reworked to subsume env creation logic. `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. The `IsolatedEnv` takes IsolatedEnvManager` as an argument instead of passing the manager's attributes to the env piecemeal. `ProjectBuilder.from_isolated_env` has been added to auto-fill init args from an isolated env. The `ProjectBuilder`'s properties were made read-only. Mutating the builder is not necessary with the addition of `from_isolated_env`. Moved runner logic to the isolated env as prelude to fixing pypa#377. As a consequence the runner is not replaceable when using isolation. Removed pip version detection. The default env updates pip in a subprocess.
layday
added a commit
to layday/build
that referenced
this issue
Oct 28, 2021
The `IsolatedEnv` has been reworked to subsume env creation logic. `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. The `IsolatedEnv` takes IsolatedEnvManager` as an argument instead of passing the manager's attributes to the env piecemeal. `ProjectBuilder.from_isolated_env` has been added to auto-fill init args from an isolated env. The `ProjectBuilder`'s properties were made read-only. Mutating the builder is not necessary with the addition of `from_isolated_env`. Moved runner logic to the isolated env as prelude to fixing pypa#377. As a consequence the runner is not replaceable when using isolation. Removed pip version detection. The default env updates pip in a subprocess.
layday
added a commit
to layday/build
that referenced
this issue
Oct 29, 2021
The `IsolatedEnv` has been reworked to subsume env creation logic. `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. The `IsolatedEnv` takes IsolatedEnvManager` as an argument instead of passing the manager's attributes to the env piecemeal. `ProjectBuilder.from_isolated_env` has been added to auto-fill init args from an isolated env. The `ProjectBuilder`'s properties were made read-only. Mutating the builder is not necessary with the addition of `from_isolated_env`. Moved runner logic to the isolated env as prelude to fixing pypa#377. As a consequence the runner is not replaceable when using isolation. Removed pip version detection. The default env updates pip in a subprocess.
layday
added a commit
to layday/build
that referenced
this issue
Oct 29, 2021
The `IsolatedEnv` has been reworked to subsume env creation logic. `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. The `IsolatedEnv` takes IsolatedEnvManager` as an argument instead of passing the manager's attributes to the env piecemeal. `ProjectBuilder.from_isolated_env` has been added to auto-fill init args from an isolated env. Moved env mangling logic to the `IsolatedEnv` as prelude to fixing pypa#377. The runner is, for now, not replaceable when using isolation. The `ProjectBuilder`'s properties were made read-only. Mutating the builder is not necessary with the addition of `from_isolated_env`. `ProjectBuilder.script_dir` was removed. Adding the `script_dir` to the path is the responsibility of the isolated env. Removed pip version detection. The default env updates pip in a subprocess.
layday
added a commit
to layday/build
that referenced
this issue
Oct 29, 2021
The `IsolatedEnv` has been reworked to subsume env creation logic. `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. The `IsolatedEnv` takes IsolatedEnvManager` as an argument instead of passing the manager's attributes to the env piecemeal. `ProjectBuilder.from_isolated_env` has been added to auto-fill init args from an isolated env. Moved env mangling logic to the `IsolatedEnv` as prelude to fixing pypa#377. The runner is, for now, not replaceable when using isolation. The `ProjectBuilder`'s properties were made read-only. Mutating the builder is not necessary with the addition of `from_isolated_env`. `ProjectBuilder.script_dir` was removed. Adding the `script_dir` to the path is the responsibility of the isolated env.
layday
added a commit
to layday/build
that referenced
this issue
Oct 29, 2021
The `IsolatedEnv` has been reworked to subsume env creation logic. `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. The `IsolatedEnv` takes IsolatedEnvManager` as an argument instead of passing the manager's attributes to the env piecemeal. `ProjectBuilder.from_isolated_env` has been added to auto-fill init args from an isolated env. Moved env mangling logic to the `IsolatedEnv` as prelude to fixing pypa#377. The runner is, for now, not replaceable when using isolation. The `ProjectBuilder`'s properties were made read-only. Mutating the builder is not necessary with the addition of `from_isolated_env`. `ProjectBuilder.script_dir` was removed. Adding the `script_dir` to the path is the responsibility of the isolated env.
layday
added a commit
to layday/build
that referenced
this issue
Oct 29, 2021
The `IsolatedEnv` has been reworked to subsume env creation logic. `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. The `IsolatedEnv` takes IsolatedEnvManager` as an argument instead of passing the manager's attributes to the env piecemeal. `ProjectBuilder.from_isolated_env` has been added to auto-fill init args from an isolated env. Moved env mangling logic to the `IsolatedEnv` as prelude to fixing pypa#377. The runner is, for now, not replaceable when using isolation. The `ProjectBuilder`'s properties were made read-only. Mutating the builder is not necessary with the addition of `from_isolated_env`. `ProjectBuilder.script_dir` was removed. Adding the `script_dir` to the path is the responsibility of the isolated env.
layday
added a commit
to layday/build
that referenced
this issue
Oct 30, 2021
The `IsolatedEnv` has been reworked to subsume env creation logic. `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. The `IsolatedEnv` takes IsolatedEnvManager` as an argument instead of passing the manager's attributes to the env piecemeal. `ProjectBuilder.from_isolated_env` has been added to auto-fill init args from an isolated env. Moved env mangling logic to the `IsolatedEnv` as prelude to fixing pypa#377. The runner is, for now, not replaceable when using isolation. The `ProjectBuilder`'s properties were made read-only. Mutating the builder is not necessary with the addition of `from_isolated_env`. `ProjectBuilder.script_dir` was removed. Adding the `script_dir` to the path is the responsibility of the isolated env.
layday
added a commit
to layday/build
that referenced
this issue
Nov 2, 2021
The `IsolatedEnv` has been reworked to subsume env creation logic. `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. The `IsolatedEnv` takes IsolatedEnvManager` as an argument instead of passing the manager's attributes to the env piecemeal. `ProjectBuilder.from_isolated_env` has been added to auto-fill init args from an isolated env. Moved env mangling logic to the `IsolatedEnv` as prelude to fixing pypa#377. The runner is, for now, not replaceable when using isolation. The `ProjectBuilder`'s properties were made read-only. Mutating the builder is not necessary with the addition of `from_isolated_env`. `ProjectBuilder.script_dir` was removed. Adding the `script_dir` to the path is the responsibility of the isolated env.
layday
added a commit
to layday/build
that referenced
this issue
Nov 2, 2021
The `IsolatedEnv` has been reworked to subsume env creation logic. `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. The `IsolatedEnv` takes IsolatedEnvManager` as an argument instead of passing the manager's attributes to the env piecemeal. `ProjectBuilder.from_isolated_env` has been added to auto-fill init args from an isolated env. Moved env mangling logic to the `IsolatedEnv` as prelude to fixing pypa#377. The runner is, for now, not replaceable when using isolation. The `ProjectBuilder`'s properties were made read-only. Mutating the builder is not necessary with the addition of `from_isolated_env`. `ProjectBuilder.script_dir` was removed. Adding the `script_dir` to the path is the responsibility of the isolated env.
layday
added a commit
to layday/build
that referenced
this issue
Nov 5, 2021
The `IsolatedEnv` has been reworked to subsume env creation logic. `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. The `IsolatedEnv` takes IsolatedEnvManager` as an argument instead of passing the manager's attributes to the env piecemeal. `ProjectBuilder.from_isolated_env` has been added to auto-fill init args from an isolated env. Moved env mangling logic to the `IsolatedEnv` as prelude to fixing pypa#377. The runner is, for now, not replaceable when using isolation. The `ProjectBuilder`'s properties were made read-only. Mutating the builder is not necessary with the addition of `from_isolated_env`. `ProjectBuilder.script_dir` was removed. Adding the `script_dir` to the path is the responsibility of the isolated env.
layday
added a commit
to layday/build
that referenced
this issue
Nov 6, 2021
* `IsolatedEnv` reworked to subsume env creation logic. * `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. * `ProjectBuilder.from_isolated_env` added to auto-fill init args from an isolated env. * Made the `IsolatedEnv` responsible for customising the environ as a prelude to fixing pypa#377. Removed `ProjectBuilder.scripts_dir`. * `ProjectBuilder`'s @properties made read-only. Mutating the builder is not necessary with the addition of `ProjectBuilder.from_isolated_env`.
layday
added a commit
to layday/build
that referenced
this issue
Nov 6, 2021
* `IsolatedEnv` reworked to subsume env creation logic. * `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. * `ProjectBuilder.from_isolated_env` added to auto-fill init args from an isolated env. * Made `IsolatedEnv` responsible for customising the environ as a prelude to fixing pypa#377. Removed `ProjectBuilder.scripts_dir`. * `ProjectBuilder`'s @properties made read-only. Mutating the builder is not necessary with the addition of `ProjectBuilder.from_isolated_env`.
layday
added a commit
to layday/build
that referenced
this issue
Jan 7, 2022
* `IsolatedEnv` reworked to subsume env creation logic. * `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`. * `ProjectBuilder.from_isolated_env` added to auto-fill init args from an isolated env. * Made `IsolatedEnv` responsible for customising the environ as a prelude to fixing pypa#377. Removed `ProjectBuilder.scripts_dir`. * `ProjectBuilder`'s @properties made read-only. Mutating the builder is not necessary with the addition of `ProjectBuilder.from_isolated_env`.
|
What's the status on this? After 1611da0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As per the discussion in #375.
This will require us to ditch
pep517for our own backend invocation implementation.I will try to look into it this weekend.
The text was updated successfully, but these errors were encountered: