Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruff to 0.0.277 #1689

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Update ruff to 0.0.277 #1689

merged 3 commits into from
Jul 21, 2023

Conversation

alexrudd2
Copy link
Collaborator

@alexrudd2 alexrudd2 commented Jul 21, 2023 •
edited
Loading

See #1687 and #1685; those should be merged first.

We have decided that implicit Optional is OK already (example foo: Optional[bar] = None is
unnecessary). The typing.ClassVar rule also seems noisy.

janiversen
janiversen approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

I learned something here, I did not know that !s worked.

@janiversen janiversen merged commit ac49b77 into dev Jul 21, 2023
@janiversen janiversen deleted the ruff branch July 21, 2023 06:37
@alexrudd2
Copy link
Collaborator Author

I learned something here, I did not know that !s worked.

I didn't either :). The pyupgrade rules in ruff have taught me many new things! I'm also impressed with the subtle bugs it's starting to catch.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrudd2 @janiversen