Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken sync client test #1685

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Fix broken sync client test #1685

merged 2 commits into from
Jul 21, 2023

Conversation

alexrudd2
Copy link
Collaborator

Closes #1684

@alexrudd2 alexrudd2 changed the title Fix broken test Fix broken sync client test Jul 20, 2023
@alexrudd2 alexrudd2 mentioned this pull request Jul 21, 2023
Merged
janiversen
janiversen approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@janiversen janiversen merged commit 65ca085 into dev Jul 21, 2023
@janiversen janiversen deleted the issue-1684 branch July 21, 2023 06:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid client tests that always pass
2 participants
@alexrudd2 @janiversen