Skip to content

Activate the RUF lints #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 5, 2024
Merged

Activate the RUF lints #618

merged 9 commits into from
Feb 5, 2024

Conversation

Armavica
Copy link
Member

Description

Follow-up of #616 and mirror of pymc-devs/pymc#7117

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Automated fixes by RUF, and update of the TensorConstructorType
type in scan/op.py because mypy didn't like something there.
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (082081a) 80.80% compared to head (dd006eb) 80.82%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
+ Coverage   80.80%   80.82%   +0.02%     
==========================================
  Files         162      162              
  Lines       46743    46744       +1     
  Branches    11419    11418       -1     
==========================================
+ Hits        37770    37783      +13     
+ Misses       6731     6716      -15     
- Partials     2242     2245       +3     
Files Coverage Δ
pytensor/breakpoint.py 55.00% <100.00%> (ø)
pytensor/compile/compilelock.py 97.14% <ø> (ø)
pytensor/configdefaults.py 65.92% <ø> (ø)
pytensor/gradient.py 76.82% <ø> (ø)
pytensor/graph/basic.py 88.76% <100.00%> (ø)
pytensor/graph/features.py 65.31% <100.00%> (ø)
pytensor/graph/rewriting/basic.py 71.03% <100.00%> (ø)
pytensor/graph/rewriting/db.py 85.96% <100.00%> (ø)
pytensor/graph/rewriting/unify.py 99.34% <100.00%> (ø)
pytensor/link/basic.py 87.39% <100.00%> (ø)
... and 44 more

Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!!!

It's interesting that 2cf51c2 was not automatic. Might be nice to drop an issue in Ruff about that one. That commit must have been a bit of work!

Looks very nice, thanks @Armavica!

Co-authored-by: Ben Mares <services-git-throwaway1@tensorial.com>
* --show-source -> --output-format=full
* renaming of some config options
* removing --line-length because it is already in the pyproject file
* taking care of some list quadratic summations
@ricardoV94
Copy link
Member

Thanks a ton @Armavica!

@ricardoV94 ricardoV94 deleted the ruff-RUF branch June 13, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants