Skip to content

Slight cleanup of the ruff configuration #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 27, 2024
Merged

Slight cleanup of the ruff configuration #616

merged 4 commits into from
Jan 27, 2024

Conversation

Armavica
Copy link
Member

Description

I cleaned up some unused lints and tried to fix #601 with ruff's (unsafe) autofix.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!

We should probably add RUF100 unused-noqa. We may also want to see what happens if we select all of RUF.

That could be done in a separate PR.

Copy link
Contributor

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow! nice

@Armavica
Copy link
Member Author

Thank you for the reviews! Is there something to do for the failing Coverage upload?

@ricardoV94
Copy link
Member

Thanks @Armavica

My guess is the codecov was just a fluke

@Armavica Armavica deleted the ruff-cleanup branch January 27, 2024 19:55
@Armavica Armavica mentioned this pull request Jan 27, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix UP031: Use format specifiers instead of percent format in code base
4 participants