Skip to content

fix(vcs): preserve index timestamp on review index to avoid racy stat cache misses #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rynfar merged 1 commit into from
Sep 21, 2026
Merged

fix(vcs): preserve index timestamp on review index to avoid racy stat cache misses #706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/server/src/vcs/GitVcsDriverCore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2355,6 +2355,13 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
prefix: `t3code-review-index-${process.pid}-`,
});
const indexExists = yield* fileSystem.exists(indexPath);
const indexStat = indexExists
? yield* fileSystem.stat(indexPath).pipe(Effect.option)
: Option.none();
const indexTime =
Option.isSome(indexStat) && Option.isSome(indexStat.value.mtime)
? Math.floor((indexStat.value.mtime.value.getTime() - 1) / 1000)
: null;
if (indexExists) yield* fileSystem.copyFile(indexPath, tempIndexPath);
const env = { GIT_INDEX_FILE: tempIndexPath } satisfies NodeJS.ProcessEnv;
const tempIndexConfig = [
Expand Down Expand Up @@ -2385,6 +2392,9 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
],
{ env, stdin: `${pathsToAdd.join("\0")}\0` },
);
if (indexTime !== null && indexTime > 0) {
yield* fileSystem.utimes(tempIndexPath, indexTime, indexTime).pipe(Effect.ignore);
}
return env;
});

Expand Down
Loading