Repository navigation
fix(vcs): preserve index timestamp on review index to avoid racy stat cache misses - #706
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #646
When copying
.git/indexto a temporary index file inprepareReviewIndex, the new temporary file gets a fresh mtime. If a tracked file was modified within the same timestamp tick as the committed index, git's stat cache comparison treats the file as unmodified because the index's mtime is newer than the file's mtime and file size is unchanged.Preserving the original index's mtime via
fileSystem.utimes(consistent withGitVcsDriver.ts) ensures Git's racy index protection remains active.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.