Polish stubs with deprecated decorator

[damusss]

After the discussion in this PR the focus of it has changed. This can be considered stubs polish.

• I changed the _to/from_string_format name to _to/from_bytes_format as the previous was referring to deprecated functions
• I removed the final import from window.pyi as Window is not a final class anymore
• Most relevant, I've added the new 3.13 (using typing_extension) @deprecated decorator to note deprecated functions and classes. This makes the stubs stay up to date with the python type systems and add useful messages (and visual effects like a strikethrough in VSCode) about deprecated features so users don't confuse them with the correct ones and are able to know if something is deprecated without documentation/running the code.

[damusss]

I realized later that some checks check if the stubs are present, so I'll convert to draft, get some feedback and decide what to do with the PR

[ankith26]

If you are doing this change, you need to add the removed API to the stubtest ignore file.

[damusss]

Alright, thanks, I didn't know that was possible, the checks are passing now.

[Starbuck5]

I would like to not do this.

Deprecations are now part of the type system in 3.13: https://peps.python.org/pep-0702/

In my VS code deprecations show up like this:

And it's backed by a pyi file that has the feature:

(Using typing_extensions since I'm on 3.9)

[damusss]

do we have some sort of access to @deprecated in the lower python supported version of pygame?

I'm sorry for the person which got pinged 💀 I forgot the code block

[damusss]

For now I added back everything adding a docstring for deprecation. Would be even better to use the deprecated decorator

[ankith26]

You can import @deprecated from typing_extensions which should serve as a backport of the feature for older python versions

[oddbookworm]

I've just got a few clarifying suggestions

[oddbookworm]

LGTM!

[ankith26]

You missed the deprecation of mouse.set_system_cursor too

[bilhox]

You missed the deprecation of mouse.set_system_cursor too

Thanks, going to add it in #2943 .

[damusss]

You missed the deprecation of mouse.set_system_cursor too

Thanks, going to add it in #2943 .

hold on, I didn't know it was deprecated, I need to add it here aswell!

[ankith26]

LGTM, thanks for the PR 🥳