Skip to content

Make deprecated API raise deprecation warnings #3001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

ankith26
Copy link
Member

While reviewing #2984 I was going over the code to see the deprecation warnings. I found 2 instances of deprecated API that do not raise the warning in code, so I fixed it in this PR

@ankith26 ankith26 requested a review from a team as a code owner July 16, 2024 09:09
Copy link
Member

@zoldalma999 zoldalma999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oddbookworm oddbookworm merged commit 7281e52 into main Jul 17, 2024
39 checks passed
@oddbookworm oddbookworm added this to the 2.5.1 milestone Jul 17, 2024
@oddbookworm oddbookworm deleted the ankith26-deprecation branch July 17, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants