Always call HasColorKey before GetColorKey #2844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDL sets an error if GetColorKey is called on a surface that doesn't have colorkey, which is much more expensive performance-wise in the newest SDL versions. Therefore, let's call SDL_HasColorKey first to avoid the error setting cost.
Starbuck5
added
the
Performance
|
I suppose this closes #2516 as well since the performance gain over 2.4.1 matches what I observed there. Apparently this regression allowed us to find a long-standing performance gap. |
I would like to keep that issue open until we have a prerelease that has had time to be tested on actual projects |
|
Gonna see if @bigwhoopgames can test a dev wheel from this pull and make sure that the performance regression is gone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDL sets an error if GetColorKey is called on a surface that doesn't have colorkey, which is much more expensive performance-wise in the newest SDL versions. Therefore, let's call SDL_HasColorKey first to avoid the error setting cost.
Successor to #2835
Closes #2821