Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a composite strategy to generate the dataframe with a tz-aware datetime column #9174

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Jun 25, 2024

This tries to use a composite strategy to generate a dataframe with a single timezone-aware datetime column. This works, but it feels somewhat weird to have to jump through hoops just get a standard timezone-aware datetime column.

@Zac-HD, do you have any advice here (as usual, time permitting)? Am I missing anything, or is this something that currently is not supported by hypothesis.extra.pandas? For context, what we have right now on main returns object dtypes, not the timezone-aware extension dtypes.

@Zac-HD
Copy link
Contributor

Zac-HD commented Jun 25, 2024

Am I missing anything, or is this something that currently is not supported by hypothesis.extra.pandas? For context, what we have right now on main returns object dtypes, not the timezone-aware extension dtypes.

I think our Pandas extra just hasn't been updated to support this yet; mind opening an issue for us?

@keewis
Copy link
Collaborator Author

keewis commented Jul 1, 2024

@dcherian, should we merge this? I can't find a way avoid the composite strategy, so this might be the best we can do right now.

@dcherian dcherian merged commit 6c2d8c3 into pydata:main Jul 1, 2024
28 checks passed
@keewis keewis deleted the extension-array-timezone branch July 1, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ Nightly upstream-dev CI failed ⚠️
3 participants