Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Nightly upstream-dev CI failed ⚠️ #9098

Closed
github-actions bot opened this issue Jun 12, 2024 · 3 comments · Fixed by #9174
Closed

⚠️ Nightly upstream-dev CI failed ⚠️ #9098

github-actions bot opened this issue Jun 12, 2024 · 3 comments · Fixed by #9174
Labels
CI Continuous Integration tools

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2024

Workflow Run URL

Python 3.12 Test Summary
xarray/tests/test_missing.py::test_scipy_methods_function[barycentric]: FutureWarning: 'd' is deprecated and will be removed in a future version. Please use 'D' instead of 'd'.
xarray/tests/test_missing.py::test_scipy_methods_function[krogh]: FutureWarning: 'd' is deprecated and will be removed in a future version. Please use 'D' instead of 'd'.
xarray/tests/test_missing.py::test_scipy_methods_function[pchip]: FutureWarning: 'd' is deprecated and will be removed in a future version. Please use 'D' instead of 'd'.
xarray/tests/test_missing.py::test_scipy_methods_function[spline]: FutureWarning: 'd' is deprecated and will be removed in a future version. Please use 'D' instead of 'd'.
xarray/tests/test_missing.py::test_scipy_methods_function[akima]: FutureWarning: 'd' is deprecated and will be removed in a future version. Please use 'D' instead of 'd'.
xarray/tests/test_missing.py::test_interpolate_pd_compat_non_uniform_index: FutureWarning: 'd' is deprecated and will be removed in a future version. Please use 'D' instead of 'd'.
@github-actions github-actions bot added the CI Continuous Integration tools label Jun 12, 2024
@keewis
Copy link
Collaborator

keewis commented Jun 12, 2024

this looks real, and possibly related to #9081. I think this can be fixed by specifying the precision in the strategy, but pandas raises lots of warnings if I add dtype="datetime64[ns]".

cc @ilan-gold, @dcherian

@ilan-gold
Copy link
Contributor

@keewis Thanks for the cc, but I really have no idea what is going on here. As I said in my PR that fixed a small roundtrip bug, this whole date-time business makes very little sense to me. It should in theory be possible to handle these as extension arrays and preserve the format, but that breaks a bunch of tests and code where the format is not expected (or this other custom data structure is expected) in very insane ways that I couldn't wrap my head around.

@keewis
Copy link
Collaborator

keewis commented Jun 18, 2024

I think the issue is not in the code, but in what we expect to get as the result of the roundtrip: if you look at the generated df, the dtype is object, while xarray returns an extension array (the former appears to have changed with pandas' main). So really, I believe the fix would be to somehow make sure we get hypothesis to generate a datetime column with time zones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants