Use backend in ds fixture #5411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds an example of parameterizing a test in dataset.py
|
Hello @max-sixty! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-06-02 16:19:13 UTC |
max-sixty
commented
May 31, 2021
| assert "unicode" in result | ||
|
|
||
|
|
||
| @pytest.fixture(params=[1]) | ||
| def ds(request): | ||
| def ds(request, backend): |
There was a problem hiding this comment.
This fixture is less elegant than I'd hoped; it now has three variations.
I think we could attempt to define one (maybe a couple) canonical datasets, and aim to use those any new tests that aren't testing something specific (e.g. some will need all missing data, but most tests have similar requirements).
Potentially that's just the result of the create_test_data function — is that our canonical dataset?
shoyer
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesFollows #5410