Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the install guide #5066

Merged
merged 5 commits into from
Mar 23, 2021
Merged

update the install guide #5066

merged 5 commits into from
Mar 23, 2021

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Mar 22, 2021

This updates the version numbers for pandas and numpy, gets rid of the warning added for pint<0.10 and updates the url for the asv monitoring page.

See #5064

  • Passes pre-commit run --all-files
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

@@ -178,7 +170,7 @@ Performance Monitoring
~~~~~~~~~~~~~~~~~~~~~~

A fixed-point performance monitoring of (a part of) our codes can be seen on
`this page <https://tomaugspurger.github.io/asv-collection/xarray/>`__.
`this page <https://pandas.pydata.org/speed/xarray/>`__.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still running? I didn't know about it! And it looks like it hasn't run in 18 months?

Copy link
Collaborator Author

@keewis keewis Mar 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the last date I could find was 2019-12-13 (about 15 months ago). That's better than the previous link (which is dead), but of course we should only link to something that's working. For reference, I copied this link from the "contributing" guide.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we remove for the moment?

I think this was on a recent funding proposal so we'll hopefully have much more here soon...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was on a recent funding proposal so we'll hopefully have much more here soon...

Yes, the benchmarking work is on the NASA proposal

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hid both links. Once we have a working setup we can uncomment them again.

Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andersy005 andersy005 merged commit ec4e8b5 into pydata:master Mar 23, 2021
@keewis keewis deleted the install-guide branch March 23, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants