Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove nep18 compatibility code #5064

Merged
merged 5 commits into from
Mar 26, 2021
Merged

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Mar 21, 2021

Since we dropped support for numpy<1.17 we can stop checking whether NEP18 has been activated.

  • Passes pre-commit run --all-files

@mathause
Copy link
Collaborator

LGTM. Can we get rid of the ubuntu-latest py37-min-nep18 CI?

@keewis
Copy link
Collaborator Author

keewis commented Mar 22, 2021

not sure. I think it was added because as per the policy we only support the latest version of NEP18 packages. These required numpy>=1.16, but now that we require numpy>=1.17 that's not that much of an issue. Also, we don't have the min-deps CI check that environment so I seem to have missed that when bumping the versions (it still installs pandas=0.25, pint=0.15, and sparse=0.8). It would probably be good to have a separate issue / PR to discuss these things.

Related to that, I just noticed that the "Installation" section in our docs is really out-of-date (among others it lists numpy=1.15 as minimum requirement and the recommends to install pint from a dev branch). I'll send in a PR to fix those.

@keewis keewis mentioned this pull request Mar 22, 2021
2 tasks
@dcherian
Copy link
Contributor

Thanks @keewis

@dcherian dcherian merged commit 8d9e897 into pydata:master Mar 26, 2021
@keewis keewis deleted the remove-nep18-compat branch March 26, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants