Support cupy in as_shared_dtype #4232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keewis
reviewed
Jul 16, 2020
There was a problem hiding this comment.
When I was working on adding pint support, I was also thinking about that (but I can't seem to find the exact issue). In the end, we implemented option , since it normally doesn't matter which unit 0 and nan have. However, this doesn't work with numpy.nanprod where _replace_nan is called with 1. In the end I didn't try to implement this because I didn't want to add code that special-cases pint (that is why e.g. DataArray.prod is not supported with pint arrays, yet).
With you also running into this issue it might make sense to generalize this: maybe get as_shared_dtype to cast to a common type instead of always casting to numpy?
…ay into as_shared_dtype_cupy
* upstream/master: Added xarrays-spatial and updated geoviews link (pydata#4262) update docs to point to xarray-contrib and xarray-tutorial (pydata#4252) Add release summary, some touch-ups (pydata#4217) CFTimeIndex calendar in repr (pydata#4092) fix the RTD timeouts (pydata#4254) update isort CI and pre-commit hook (pydata#4204)
|
Failed test is #4265 I'm merging so things can keep moving. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements solution 2 for #4231.
cc @quasiben
isort -rc . && black . && mypy . && flake8