-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
update isort CI and pre-commit hook #4204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
it seems While having such a conflict indicates poor design, this is actually not the same: Not sure if we have any dependency where these changes are dangerous? We should probably pin Edit: see PyCQA/isort#1280 |
|
Thanks @keewis . Interesting re the difference in import functionality; I didn't know that. I'm fine either way; to the extent the tests pass on the revised format, I'd be fine moving to that. |
|
Great! Thanks @keewis ! |
* upstream/master: Added xarrays-spatial and updated geoviews link (pydata#4262) update docs to point to xarray-contrib and xarray-tutorial (pydata#4252) Add release summary, some touch-ups (pydata#4217) CFTimeIndex calendar in repr (pydata#4092) fix the RTD timeouts (pydata#4254) update isort CI and pre-commit hook (pydata#4204)
Now that the conda-forge feedstock has been updated, we would see a failing
isortCI because of the removed-rc(short for--recursive). I also updated the version used bypre-committo the5.0.4version released about an hour ago, which allows us to remove the file regex as recommended by @asottile in #3750 (comment) (we couldn't follow that advice before since we were using theuse_parenthesessetting which was broken on4.3.21)isort . && black . && mypy . && flake8whats-new.rstapi.rst