This repository was archived by the owner on Sep 16, 2024. It is now read-only.
Return None for unknown nvs_get keys #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ustruct: Pull in ustruct module from the Micropython.org tree
New IDF needs a new toolchain
Currently the `nvs_get` function will initialize unknown values to 0. This results in two problems: * Every read on an unknown key will result in a write. * It is not possible to discern a value that has been set to 0, and a value that does not exist. By returning `None` for unknown values, discerning missing and 0 values becomes possible.
|
Merged long ago, thanks. New API functions were added to erase the NRAM area in case it gets full. |
X-Ryl669
pushed a commit
to X-Ryl669/pycom-micropython-sigfox
that referenced
this pull request
May 12, 2023
pyjtag clarifications
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
nvs_getfunction will initialize unknown values to 0. This results in two problems:By returning
Nonefor unknown values, discerning missing and 0 values becomes possible.Note: There are some additional problems with the nvs functionality:
nvs_*functions useless without compiling custom firmwaremp_obj_new_intifnvs_get_u32returns an error code other thanESP_ERR_NVS_NOT_FOUND.Note: This would of course have to be mentioned in the release notes, since it's a breaking change (the return type is changed).